Some new functions and updated comments #256
Conversation
…thub.com/jakkulabs/PowervRA into bugfix-update-connect-vraserver-function
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
| @@ -214,3 +213,7 @@ function New-vRAVirtualDisk { | |||
|
|
|||
| } | |||
| } | |||
|
|
|||
| New-Alias -Name New-vRABlockDevice -Value New-vRAVirtualDisk | |||
| Export-ModuleMember -Alias * -Function * | |||
There was a problem hiding this comment.
@chelnak What do you think about this? Should we put any aliases into the module manifest rather than left in the code for a function?
If so, I guess we need to update the build process to get them in the right place automatically.
There was a problem hiding this comment.
I will leave this one, but fix the other suggestions. I did this here because I was not aware of where else to do it. Is there a better procedure here? If so, I can just do that.
There was a problem hiding this comment.
I think a "clean" way to handle aliases is to use an alias attribute:
[CmdletBinding()]
[Alias("New-vRABlockDevice")]
PARAM ()
Then export them in the module manifest.
Thoughts?
There was a problem hiding this comment.
I like that idea, seems easy to implement and use
There was a problem hiding this comment.
I like it 👍🏻
@Stevio54 Can you update the function to implement the alias in that way and remove the Export-ModuleMember command. Then after merging, I'll update the build code in another branch to add any aliases implemented this way into the generated manifest.
Co-authored-by: Jonathan Medd <[email protected]>
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
Odd, there are build issues, let me work through these as well. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Hello Everyone, was hoping to have much higher coverage of IaaS at this point; However, here is what I have so far:
src/Functions/Public/iaas/Update-vRAvSphereFabricNetwork.ps1
src/Functions/Public/iaas/Update-vRAProject.ps1
src/Functions/Public/iaas/Update-vRAExternalNetworkIPRange.ps1
src/Functions/Public/iaas/Resize-vRAVirtualDisk.ps1
src/Functions/Public/iaas/New-vRANetworkProfile.ps1
src/Functions/Public/iaas/Get-vRAvSphereFabricNetwork.ps1
Each of those functions are new, and are included in this pull request. More work is ongoing.
Note: This branch is merged already with updates from "bugfix-update-connect-vraserver" so should be merged after that one.