Adding Property Group functions to the properties-service #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
reviewed
Mar 1, 2019
|
Yes, I will work on that now. Thanks :) |
|
Ok, just added tests into the properties-service test file. Please review and let me know if I need to make any changes to them. |
chelnak
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
Approved from my side.
@jonathanmedd Can you take a look too please?
jonathanmedd
requested changes
Mar 8, 2019
src/Functions/Public/properties-service/Get-vRAPropertyGroup.ps1
Outdated
Show resolved
Hide resolved
src/Functions/Public/properties-service/Get-vRAPropertyGroup.ps1
Outdated
Show resolved
Hide resolved
src/Functions/Public/properties-service/New-vRAPropertyGroup.ps1
Outdated
Show resolved
Hide resolved
src/Functions/Public/properties-service/New-vRAPropertyGroup.ps1
Outdated
Show resolved
Hide resolved
src/Functions/Public/properties-service/New-vRAPropertyGroup.ps1
Outdated
Show resolved
Hide resolved
src/Functions/Public/properties-service/New-vRAPropertyGroup.ps1
Outdated
Show resolved
Hide resolved
src/Functions/Public/properties-service/Remove-vRAPropertyGroup.ps1
Outdated
Show resolved
Hide resolved
|
I am working on these changes now, and will have them submitted by the end of this week. Some of these I found while looking over the code after the pull request, apologies for missing them. |
|
Ok, I have made all requested changes and submitted as of now :) Thanks fellas. |
jonathanmedd
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this is my first pull request for this repository. I am a Consultant and as a requirement for a client I am helping now, I would like to add these three functions to interact with the Property Group endpoints of the properties-service.
Of course, please review and give me any suggested changes you may need.