Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set-vRATenantDirectorySync #187

Merged
merged 10 commits into from
Jan 10, 2019
Merged

Set-vRATenantDirectorySync #187

merged 10 commits into from
Jan 10, 2019

Conversation

basvinken
Copy link
Contributor

added allusers parameter to Set-vRAEntitlement.ps1
created Set-vRATenantDirectorySync.ps1 to force directory sync

@jonathanmedd jonathanmedd added this to the 3.4.0 milestone Sep 14, 2018
jonathanmedd
jonathanmedd requested changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@jonathanmedd jonathanmedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution and many apologies for taking so long to review the PR. (It has not been a good few months for a few reasons in terms of getting any time to spend on this project )

src/Functions/Public/catalog-service/Set-vRAEntitlement.ps1 Outdated Show resolved Hide resolved
src/Functions/Public/identity/Set-vRATenantDirectorySync.ps1 Outdated Show resolved Hide resolved
src/Functions/Public/identity/Set-vRATenantDirectorySync.ps1 Outdated Show resolved Hide resolved
src/Functions/Public/identity/Set-vRATenantDirectorySync.ps1 Outdated Show resolved Hide resolved
src/Functions/Public/identity/Set-vRATenantDirectorySync.ps1 Outdated Show resolved Hide resolved
jonathanmedd
jonathanmedd requested changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@jonathanmedd jonathanmedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the updates look good. Please just address the additional comment I have made about the examples now needing updating to use the new name, then we can merge this. Thanks.

src/Functions/Public/identity/Set-vRATenantDirectorySync.ps1 Outdated
System.Management.Automation.PSObject.

.EXAMPLE
Set-vRATenantDirectorySync -Id Tenant01 -Domain vrademo.local
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two Examples now need to be updated to use the new name, Invoke-vRATenantDirectorySync.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed the file and updated the Examples

@jonathanmedd jonathanmedd merged commit bd57be5 into jakkulabs:master Jan 10, 2019
@jonathanmedd
Copy link
Contributor

@basvinken Thanks again for your contribution - it will be included in the 3.4.0 release which is imminent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanmedd jonathanmedd jonathanmedd approved these changes

@chelnak chelnak Awaiting requested review from chelnak

Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@basvinken @jonathanmedd