Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConvertTo-Json in Connect-vRAServer #175

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Use ConvertTo-Json in Connect-vRAServer #175

merged 1 commit into from
Feb 22, 2018

Conversation

mponton
Copy link
Contributor

@mponton mponton commented Feb 21, 2018

Creating JSON using embedded variables in a string can easily break if the user's input contains special characters. In my case, my password would break the encoding and the server would error out. This can be the case, for example, if the password contains a double quote, ends with a backslash, etc...

Creating JSON using embedded variables in a string can easily break if the user's input contains special characters. In my case, my password would break the encoding and the server would error out. This can be the case, for example, if the password contains a double quote, ends with a backslash, etc...
@jonathanmedd jonathanmedd added this to the 3.1.1 milestone Feb 22, 2018
@jonathanmedd jonathanmedd self-requested a review February 22, 2018 10:07
Copy link
Contributor

@jonathanmedd jonathanmedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - thanks a lot!
Have tested the change and all is good. It fixes the issue described.

@chelnak chelnak merged commit d2c7402 into jakkulabs:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants