forked from apache/giraph
-
Notifications
You must be signed in to change notification settings - Fork 1
/
CODE_CONVENTIONS
81 lines (65 loc) · 2.29 KB
/
CODE_CONVENTIONS
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
This codebase follows the Oracle "Code Conventions for the Java
Programming Language". See the following link:
http://www.oracle.com/technetwork/java/codeconvtoc-136057.html
In addition, this project has several rules that are more specific:
- No line should use more than 79 characters
- No tabs, only spaces
- All indents should be 2 spaces (or 4 when there is confusion)
if (<short expression>) {
return true;
}
if (<very, very, very long expression that continues and wraps around this
line, use 4 spaces on this following line>) {
return true;
}
- Given there are many generic types, there will be long class definitions.
Wrap the line as follows:
public class BspServiceMaster<I extends WritableComparable, V extends Writable,
E extends Writable, M extends Writable> extends BspService<I, V, E, M>
implements CentralizedServiceMaster<I, V, E, M> {
/** Class logger */
private static final Logger LOG = Logger.getLogger(BspServiceMaster.class);
}
- All while/if/else must have brackets, even if there there is only a one
line statement following. 'else' and 'else if' are expected to line up
with the '}'. For example:
if (condition) {
statement;
}
if (condition) {
statement;
} else {
statement;
}
- Any use of LOG should be enclosed with an is*Enabled() method. For example:
if (LOG.isInfoEnabled()) {
LOG.info("something happened");
}
- All classes, members, and member methods should have Javadoc in the following
style. C-style comments for javadoc and // comments for non-javadoc.
/**
* This is an example class
*/
public class Giraffe {
/** Number of spots on my giraffe */
private int spots;
/**
* Example horribly long comment that wraps around the line. If it is very,
* very, very long.
*/
private int feet;
/**
* How many seconds to travel a number of steps
*
* @param steps Steps to travel
* @param stepsPerSec Steps a giraffe travels every second
* @return Number of seconds
*/
public static int secToTravel(int steps, int stepsPerSec) {
// Simple formula to get time to travel
return steps / stepsPerSec;
}
}
- Class members should not begin with 'm_' or '_'.
- No warnings allowed, but be as specific as possible with warning suppression
- Prefer to avoid abbreviations when reasonable (i.e. 'msg' vs 'message')