Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding lib jars to the web archive in TCK may result in an error if the path to the jar has escapable symbols #284

Open
marko-bekhta opened this issue Jun 4, 2024 · 0 comments
Assignees
Labels
accepted Accepted certification request challenge TCK challenge

Comments

@marko-bekhta
Copy link

When the Validation TCK base test adds a few lib dependencies to the web archive, if the dependency path contains escapable symbols, e.g. @, the TCK will fail to find an actual jar, resulting in an entire TCK failing.

CodeSource#getLocation(), which is used to obtain the path to the added lib returns an URL that keeps the escaped symbols in the path.

The suggestion is to resolve the path by converting the URL to URI.

In particular, this can happen on CI where the jars are located in a directory with paths similar to /var/lib/jenkins/workspace/hibernate-validator_smth@tmp

See also jakartaee/validation-tck#198 (comment) for the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Accepted certification request challenge TCK challenge
Projects
None yet
Development

No branches or pull requests

2 participants