[#815] Indicate that JAXB is optional #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy McCright <[email protected]>
andymc12
requested review from
chkal,
asoldano,
mkarg,
arjantijms,
spericas,
kwsutter and
jansupol
mkarg
requested changes
Mar 10, 2020
kwsutter
approved these changes
Mar 10, 2020
| also include those for JSON. For more information about these providers | ||
| see <<jsonp>> and <<jsonb>>. | ||
| also include those for JSON or XML. For more information about these providers | ||
| see <<jsonp>>, <<jsonb>> and <<jaxb>>. |
There was a problem hiding this comment.
I like the oxford comma after <<jsonb>>, but maybe that's just me... :-)
spericas
approved these changes
Mar 11, 2020
|
@mkarg - you're right. no fast track on this one. Thanks for pointing it out. You have requested changes, but I didn't see any comments indicating what you'd like to see changed. @kwsutter I don't have a strong opinion about the extra comma - I've seen it both ways (with and without a comma before the last object). If you're ok with it, I'll leave it as-is unless there are other changes that need to go in. Thanks! |
mkarg
approved these changes
Mar 11, 2020
|
@andymc12 Why not merging this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications to the spec doc and javadoc that indicate that JAXB is optional. Where possible, I tried to keep the language consistent with JSON-P / JSON-B - i.e. if the product supports JSON-B, then it must have a built-in entity provider to handle JSON requests - likewise for JAXB / XML.
This change is targeted for the
masterbranch (3.0), and should also go into the3.1-SNAPSHOTbranch.Fixes #815