Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the jpa-platform test usage of the ServiceEETest class #1418

Closed
starksm64 opened this issue Jul 24, 2024 · 7 comments
Closed

Restore the jpa-platform test usage of the ServiceEETest class #1418

starksm64 opened this issue Jul 24, 2024 · 7 comments
Assignees

Comments

@starksm64
Copy link
Contributor

No description provided.

@starksm64 starksm64 converted this from a draft issue Jul 24, 2024
@scottmarlow scottmarlow self-assigned this Jul 24, 2024
@scottmarlow
Copy link
Contributor

This makes sense also, will give this a shot.

@scottmarlow
Copy link
Contributor

scottmarlow commented Aug 5, 2024

For reference, in EE 10, I think there are around 10,989 Persistence tests that WildFly runs for Platform TCK testing.

Currently with the EE 11 Platform TCK refactoring OpenRewrite recipe, I see that we parsed around 2117 tests as per "grep testName:" tck.log | wc -l.

Need to understand this better.

@scottmarlow
Copy link
Contributor

Looks like we do need to process the JavaDoc entries also when parsing Java comments.

@scottmarlow
Copy link
Contributor

With a change to also parse Javadoc comments the count of processed persistence tests is 2177 which may be correct as we are generating around 1294 new test files each of which is dedicated for a specific vehicle.

From a further check of the generated JPA source files, we have 10794 new tests that are tagged as @test which is close to the 10989 test count mentioned above. So, we can proceed forward now.

@scottmarlow
Copy link
Contributor

eclipse-ee4j/jakartaee-tck-tools#84 addressed ^ test count concern.

@scottmarlow
Copy link
Contributor

As a cross check, in the 10.0.x branch, I see 2180 @testname tests under the src/com/sun/ts/tests/jpa folder.

@scottmarlow
Copy link
Contributor

The jpa/** tests were changed to (indirectly) extend the ServiceEETest class. The jpa-tck/** tests were created which do not extend the ServiceEETest classes.

@github-project-automation github-project-automation bot moved this from Ready to Assign to Done in Jakarta EE11 TCK Release Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants