-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore the jpa-platform test usage of the ServiceEETest class #1418
Comments
This makes sense also, will give this a shot. |
For reference, in EE 10, I think there are around 10,989 Persistence tests that WildFly runs for Platform TCK testing. Currently with the EE 11 Platform TCK refactoring OpenRewrite recipe, I see that we parsed around 2117 tests as per Need to understand this better. |
Looks like we do need to process the JavaDoc entries also when parsing Java comments. |
With a change to also parse Javadoc comments the count of processed persistence tests is From a further check of the generated JPA source files, we have 10794 new tests that are tagged as @test which is close to the |
eclipse-ee4j/jakartaee-tck-tools#84 addressed ^ test count concern. |
As a cross check, in the 10.0.x branch, I see 2180 @testname tests under the src/com/sun/ts/tests/jpa folder. |
The jpa/** tests were changed to (indirectly) extend the ServiceEETest class. The jpa-tck/** tests were created which do not extend the ServiceEETest classes. |
No description provided.
The text was updated successfully, but these errors were encountered: