Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies never be used #31

Closed
rieonke opened this issue May 17, 2019 · 5 comments
Closed

Dependencies never be used #31

rieonke opened this issue May 17, 2019 · 5 comments
Milestone

Comments

@rieonke
Copy link

rieonke commented May 17, 2019

The interceptor api declared 2 deps common-annotations and ejb in the pom.xml,
but none of them has been imported, so can we remove it?
https://github.com/eclipse-ee4j/interceptor-api/blob/8eb1e608ad81c06ddfd147a077c06cad2b46f9a2/pom.xml#L322-L334

➜  interceptor-api git:(EE4J_8) find . -name \*.java -exec grep "import javax" {} \;
➜  interceptor-api git:(EE4J_8) 
@romain-grecourt
Copy link

These 2 dependencies were not present in javax.interceptor:javax.interceptor-api.
They were added by this commit: ae60a79

These new dependencies are actually exposed transitively, so basically cdi-api now depends on ejb-api:

+- jakarta.enterprise:jakarta.enterprise.cdi-api:jar:2.0.2:provided
[INFO] |  +- jakarta.el:jakarta.el-api:jar:3.0.3:provided
[INFO] |  +- jakarta.interceptor:jakarta.interceptor-api:jar:1.2.5:provided
[INFO] |  |  +- jakarta.annotation:jakarta.annotation-api:jar:1.3.5:provided
[INFO] |  |  \- jakarta.ejb:jakarta.ejb-api:jar:3.2.6:provided
[INFO] |  |     \- jakarta.transaction:jakarta.transaction-api:jar:1.3.2:provided
[INFO] |  \- jakarta.inject:jakarta.inject-api:jar:1.0:provided

They are likely used to resolve the javadoc links to both ejb and annotation API.

@keilw
Copy link
Member

keilw commented Sep 13, 2019

If it's just in the JavaDoc and there is no dependency, not even an optional one, then it could be removed I guess. And the reference ideally should be removed and {@link javax.ejb.Timer} replaced e.g. by {@code javax.ejb.Timer} which has the same formatting effect.

@arjantijms
Copy link
Contributor

Fixed by Jonathan @Cousjava

Thanks to everyone contributing to this. There might be some other specifications that have this same issue, so would be good to look at other specs too for this.

@jmartisk
Copy link

Hi @arjantijms could we please ask you to get 1.2.6 released soon? MicroProfile is moving to align with Jakarta EE dependencies and we'd like to avoid having to exclude the EJB dependency on the platform side (EJB clearly doesn't belong into MicroProfile)

@keilw
Copy link
Member

keilw commented Dec 29, 2019

I guess that's up to a particular feature, there's so much stuff in MicroProfile these days, that even the EJB 3+ that's also used in the Web Profile sounds not unreasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants