Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Define basic terms: "entity", "repository", "identifier", etc. #245

Merged
merged 6 commits into from
Sep 6, 2023

Conversation

otaviojava
Copy link
Contributor

Hey everyone, based on the Issue, I merged it into what we already have in our documentation.

Please let me know what you think about it.

Proposal work to: #244

@otaviojava otaviojava added documentation Improvements or additions to documentation help wanted Extra attention is needed jpa Something JPA-specific nosql Something NoSQL-specific labels Sep 6, 2023
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly this looks really good. I added comments for a few corrections to make.

spec/src/main/asciidoc/repository.asciidoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/repository.asciidoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/repository.asciidoc Outdated Show resolved Hide resolved
@otaviojava otaviojava merged commit 9d296b8 into main Sep 6, 2023
2 checks passed
@otaviojava otaviojava deleted the update-entity-repository-definition branch September 6, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed jpa Something JPA-specific nosql Something NoSQL-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants