Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomCDIProviderTest is incorrect #217

Closed
manovotn opened this issue Dec 4, 2020 · 0 comments · Fixed by #218
Closed

CustomCDIProviderTest is incorrect #217

manovotn opened this issue Dec 4, 2020 · 0 comments · Fixed by #218

Comments

@manovotn
Copy link
Contributor

manovotn commented Dec 4, 2020

@starksm64 This change became incorrect after accepting the following change into cdi master - jakartaee/cdi#445

The test asserts that you can return a provider which return null for its getCDI() call, but the code now guards against it.
I will send a fix for this shortly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix CustomCDIProviderTest by supplying an impl that doesn't return nu… manovotn/cdi-tck
1 participant
@manovotn