Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On branch edburns-msft-1410-arquillian-version Update arquillian version. #82

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edburns
Copy link

@edburns edburns commented Aug 7, 2024

… See jakartaee/platform-tck#1410

modified: com.ibm.jbatch.tck.ann.proc/pom.xml
modified: com.ibm.jbatch.tck.ann/pom.xml
modified: com.ibm.jbatch.tck.appbean/pom.xml
modified: com.ibm.jbatch.tck.exec/pom.xml
modified: com.ibm.jbatch.tck.sigtest.exec/pom.xml
modified: com.ibm.jbatch.tck.spi/pom.xml
modified: com.ibm.jbatch.tck/pom.xml
modified: jakarta.batch.arquillian.exec-parent/pom.xml
modified: jakarta.batch.arquillian.exec/pom.xml
modified: jakarta.batch.arquillian.extension/pom.xml
modified: jakarta.batch.official.tck/pom.xml
modified: jakarta.batch.reporting/pom.xml
modified: jakarta.batch.tck.util/pom.xml
modified: pom.xml

…ion. See jakartaee/platform-tck#1410

modified:   com.ibm.jbatch.tck.ann.proc/pom.xml
modified:   com.ibm.jbatch.tck.ann/pom.xml
modified:   com.ibm.jbatch.tck.appbean/pom.xml
modified:   com.ibm.jbatch.tck.exec/pom.xml
modified:   com.ibm.jbatch.tck.sigtest.exec/pom.xml
modified:   com.ibm.jbatch.tck.spi/pom.xml
modified:   com.ibm.jbatch.tck/pom.xml
modified:   jakarta.batch.arquillian.exec-parent/pom.xml
modified:   jakarta.batch.arquillian.exec/pom.xml
modified:   jakarta.batch.arquillian.extension/pom.xml
modified:   jakarta.batch.official.tck/pom.xml
modified:   jakarta.batch.reporting/pom.xml
modified:   jakarta.batch.tck.util/pom.xml
modified:   pom.xml

Signed-off-by: Ed Burns <[email protected]>
Copy link
Contributor

@scottkurz scottkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

The latest release is 2.1.5, so the 2.2.0-SNAPSHOT is I think fine to stay with.

@liweinan
Copy link

liweinan commented Aug 9, 2024

@scottkurz
Copy link
Contributor

In addition, there may be more configuration changes that need to be done for the upgrade. Here are some PRs for reference:

I didn't see anything we obviously need from those PRs @liweinan. It looked mostly like POM imports. Feel free to suggest additional commits or changes but if it seems to work with the current PR, I'd guess we might be able to stop there.

@liweinan
Copy link

liweinan commented Aug 9, 2024

@scottkurz Okay!

We've met some dep chain problems during the work on the PRs pasted above(For example, some shrinkwrap poms were added after this upgrade). If all the tests are passed here there is no problem.

@scottkurz
Copy link
Contributor

@edburns this change seems to work, I tested it.

I sent you a PR azure-javaee#1 if you want to merge it to revert the version update. Or I could just make the change.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants