Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): adding mvc folder structure #84

Closed
wants to merge 0 commits into from
Closed

feat(backend): adding mvc folder structure #84

wants to merge 0 commits into from

Conversation

JainPriya1234
Copy link

@JainPriya1234 JainPriya1234 commented Jun 6, 2023 •
edited
Loading

Related Issue

Mvc folder structure added

Closes: adding MVC folder structure #59

Describe the changes you've made

I have put all files in proper folder following MVC pattern. The files are imported and exported correctly maintaining their functionality.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement in the existing features
  • Other

Mention any unusual behaviour of your code (Write NA if not)

Any unusual behaviour of your code

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • My changes generate no new warnings.
  • I have verified/tested my code by running it locally.

Files Added/Modified

  • models
  • router
  • controller
  • validations
  • utlits
  • db

Screenshots / Videos / Gif

image

Additional Info (optional)

Any additional information you want to give

@JainPriya1234
Copy link
Author

@apeksha235 Please review my PR on issue #59

@apeksha235
Copy link
Collaborator

hey @JainPriya1234 please change the title of the pr according to the naming convention in contribution.md also have you tested this?

@JainPriya1234 JainPriya1234 changed the title MVC FOLDER STRUCTURE ADDED Added MVC folder structure Jun 7, 2023
@JainPriya1234
Copy link
Author

hey @JainPriya1234 please change the title of the pr according to the naming convention in contribution.md also have you tested this?

yes @apeksha235 I tested it and please let me know now is PR title correct

@JainPriya1234 JainPriya1234 changed the title Added MVC folder structure added mnc folder structure Jun 7, 2023
@JainPriya1234 JainPriya1234 changed the title added mnc folder structure adding mvc folder structure Jun 7, 2023
@JainPriya1234
Copy link
Author

JainPriya1234 commented Jun 7, 2023 •
edited
Loading

@apeksha235 let me know if I have to make the PR again so that it can follow all the checks of contribution.md

@JainPriya1234 JainPriya1234 changed the title adding mvc folder structure adding mvc folder structure and resolving issue #59 Jun 7, 2023
@apeksha235
Copy link
Collaborator

@JainPriya1234 you will have to add "feat(backend)" as well like given in the instructions

@JainPriya1234 JainPriya1234 changed the title adding mvc folder structure and resolving issue #59 feat(backend) : adding mvc folder structure Jun 10, 2023
@JainPriya1234 JainPriya1234 changed the title feat(backend) : adding mvc folder structure feat(backend): adding mvc folder structure Jun 10, 2023
@JainPriya1234
Copy link
Author

@apeksha235 please review it

@JainPriya1234
Copy link
Author

JainPriya1234 commented Jun 21, 2023 •
edited
Loading

@jain-rishabh-21 @apeksha235 please check this PR format as I updated it

@jain-rishabh-21
Copy link
Owner

@JainPriya1234 Can you resolve the merge conflicts please?

@JainPriya1234
Copy link
Author

@jain-rishabh-21 I tried to resolve it but someone has done the same work as what is assigned to me that's why it is creating conflicts so I discarded my commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jain-rishabh-21 jain-rishabh-21 jain-rishabh-21 approved these changes

Assignees

@JainPriya1234 JainPriya1234

Labels
gssoc23 level1 bug/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add proper UserController
3 participants
@JainPriya1234 @apeksha235 @jain-rishabh-21