Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Primops #25

Open
jafioti opened this issue Feb 27, 2024 · 1 comment
Open

Removing Primops #25

jafioti opened this issue Feb 27, 2024 · 1 comment
Labels
advanced Issues requiring good knowledge of the codebase

Comments

@jafioti
Copy link
Owner

jafioti commented Feb 27, 2024

  • Remove sqrt by doing x.pow(0.5)
    This requires selectors to reference the same node multiple times.
  • Also remove mul, mul is just a.log2().add(b.log2()).exp2(), and div is just a.log2().sub(b.log2()).exp2()
  • Remove recip, because recip is just 1 / x
@jafioti jafioti added the advanced Issues requiring good knowledge of the codebase label Mar 1, 2024
@jafioti
Copy link
Owner Author

jafioti commented Mar 1, 2024

Is it possible to define mod in terms of other primops? I believe not. Also what about LessThan? Perhaps through some crazy concat -> maxreduce -> equals or something, but might not be worth the complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
advanced Issues requiring good knowledge of the codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jafioti