[jaeger-v2] Enable queueing configuration in storage exporter #6080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6080 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 351 351
Lines 16675 16675
=======================================
Hits 16162 16162
Misses 329 329
Partials 184 184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Oct 14, 2024
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
added
the
changelog:exprimental
yurishkuro
approved these changes
Oct 14, 2024
chahatsagarmain
pushed a commit
to chahatsagarmain/jaeger
that referenced
this pull request
Oct 23, 2024
…tracing#6080) ## Which problem is this PR solving? - Towards jaegertracing#6040 ## Description of the changes - Added the `sending_queue` configuration to `jaeger_storage_exporter` from`exporterhelper` which will allow for enabling a queue when writing spans to any backend store. - This will allow for achieving parity in jaeger-v2 with the v1 collector's `--collector.queue-size` flag as `sending_queue` has a configuration for `queue_size`. - [Migration guide](https://docs.google.com/document/d/18B1yTMewRft2N0nW9K-ecVRTt5VaNgnrPTW1eL236t4/edit?usp=sharing) updated for the mapping between v1 and v2 ## How was this change tested? - ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
sending_queueconfiguration tojaeger_storage_exporterfromexporterhelperwhich will allow for enabling a queue when writing spans to any backend store.--collector.queue-sizeflag assending_queuehas a configuration forqueue_size.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test