diff --git a/plugin/storage/es/spanstore/reader.go b/plugin/storage/es/spanstore/reader.go index 5b0caa50fbd..1303155c551 100644 --- a/plugin/storage/es/spanstore/reader.go +++ b/plugin/storage/es/spanstore/reader.go @@ -90,7 +90,6 @@ var ( // SpanReader can query for and load traces from ElasticSearch type SpanReader struct { - ctx context.Context client es.Client logger *zap.Logger // The age of the oldest service/operation we will look for. Because indices in ElasticSearch are by day, @@ -119,9 +118,7 @@ type SpanReaderParams struct { // NewSpanReader returns a new SpanReader with a metrics. func NewSpanReader(p SpanReaderParams) *SpanReader { - ctx := context.Background() return &SpanReader{ - ctx: ctx, client: p.Client, logger: p.Logger, maxSpanAge: p.MaxSpanAge, @@ -337,7 +334,7 @@ func (s *SpanReader) multiRead(ctx context.Context, traceIDs []model.TraceID, st } // set traceIDs to empty traceIDs = nil - results, err := s.client.MultiSearch().Add(searchRequests...).Index(indices...).Do(s.ctx) + results, err := s.client.MultiSearch().Add(searchRequests...).Index(indices...).Do(ctx) if err != nil { logErrorToSpan(childSpan, err) @@ -471,7 +468,6 @@ func (s *SpanReader) findTraceIDs(ctx context.Context, traceQuery *spanstore.Tra // } aggregation := s.buildTraceIDAggregation(traceQuery.NumTraces) boolQuery := s.buildFindTraceIDsQuery(traceQuery) - jaegerIndices := s.timeRangeIndices(s.spanIndexPrefix, traceQuery.StartTimeMin, traceQuery.StartTimeMax) searchService := s.client.Search(jaegerIndices...). @@ -480,7 +476,7 @@ func (s *SpanReader) findTraceIDs(ctx context.Context, traceQuery *spanstore.Tra IgnoreUnavailable(true). Query(boolQuery) - searchResult, err := searchService.Do(s.ctx) + searchResult, err := searchService.Do(ctx) if err != nil { return nil, errors.Wrap(err, "Search service failed") } diff --git a/plugin/storage/es/spanstore/reader_test.go b/plugin/storage/es/spanstore/reader_test.go index f2ec9bdd52a..7f12d94cd87 100644 --- a/plugin/storage/es/spanstore/reader_test.go +++ b/plugin/storage/es/spanstore/reader_test.go @@ -803,7 +803,7 @@ func mockMultiSearchService(r *spanReaderTest) *mock.Call { multiSearchService.On("Index", mock.AnythingOfType("string"), mock.AnythingOfType("string"), mock.AnythingOfType("string"), mock.AnythingOfType("string"), mock.AnythingOfType("string")).Return(multiSearchService) r.client.On("MultiSearch").Return(multiSearchService) - return multiSearchService.On("Do", mock.AnythingOfType("*context.emptyCtx")) + return multiSearchService.On("Do", mock.AnythingOfType("*context.valueCtx")) } func mockArchiveMultiSearchService(r *spanReaderTest, indexName string) *mock.Call { @@ -811,7 +811,7 @@ func mockArchiveMultiSearchService(r *spanReaderTest, indexName string) *mock.Ca multiSearchService.On("Add", mock.Anything, mock.Anything, mock.Anything).Return(multiSearchService) multiSearchService.On("Index", indexName).Return(multiSearchService) r.client.On("MultiSearch").Return(multiSearchService) - return multiSearchService.On("Do", mock.AnythingOfType("*context.emptyCtx")) + return multiSearchService.On("Do", mock.AnythingOfType("*context.valueCtx")) } func mockSearchService(r *spanReaderTest) *mock.Call {