-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaeger-v2]: Fix Kafka E2E Test To Use Default Environment Variables #6027
Comments
@yurishkuro Would you be able to help me understand why we needed |
Because we want to test the one official config we provide, not create copies of it that may become out of date. |
@yurishkuro got it! and does setting the environment variable take precedent over the config in the YAML file? |
It does not. If config has a fixed value the env variable is not going to affect it. Previously you could reference env variable from the config, but then you always have to provide the variable, otherwise the config is invalid. Now you could have both - a default value and a way to override it via env variable. |
@yurishkuro Thanks for the explanation! PR is ready for review at #6028. |
Problem
The text was updated successfully, but these errors were encountered: