Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-v2] Align Memory Storage Config With OTEL #5923

Closed
6 tasks done
mahadzaryab1 opened this issue Sep 2, 2024 · 0 comments · Fixed by #5925
Closed
6 tasks done

[jaeger-v2] Align Memory Storage Config With OTEL #5923

mahadzaryab1 opened this issue Sep 2, 2024 · 0 comments · Fixed by #5925
Labels
area/otel area/storage changelog:new-feature Change that should be called out as new feature in CHANGELOG enhancement v2

Comments

@mahadzaryab1
Copy link
Collaborator

mahadzaryab1 commented Sep 2, 2024

Requirement

In this issue, we want to align the configuration for memory storage with OTEL (part of #5229)

Tasks / outcomes

  • All config fields are tagged with mapstructure such that they can be addressable from YAML via "good" names
  • Configs implement Validate()
  • Configs via YAML support the same defaults as in jaeger-v1
  • Configs reuse standard elements of OTEL configs whenever possible, e.g. TLS, clientcfg, etc. (N/A)
  • Configuration looks "logical" and properly grouped, not flattened with long weird names
  • We create a migration guide document with a table that lists v1 CLI flags and the corresponding v2 config fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/otel area/storage changelog:new-feature Change that should be called out as new feature in CHANGELOG enhancement v2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant