Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Zipkin.thrift #335

Closed
yurishkuro opened this issue Aug 15, 2017 · 1 comment
Closed

Update Zipkin.thrift #335

yurishkuro opened this issue Aug 15, 2017 · 1 comment
Milestone
Drop-in Replaceme...

Comments

@yurishkuro
Copy link
Member

Our zipkin.thrift is out of date and missing some fields like 128bit trace ID and ipv6.

https://github.com/uber/jaeger/pull/334#discussion_r133116969
@yurishkuro yurishkuro mentioned this issue Aug 15, 2017
Closed
@pavolloffay pavolloffay mentioned this issue Aug 15, 2017
Merged
@pavolloffay
Copy link
Member

@black-adder could you please re-open? And close once thrift-gen is updated.

(It was automatically closed)

@black-adder black-adder reopened this Aug 15, 2017
@yurishkuro yurishkuro mentioned this issue Sep 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Drop-in Replacement for Zipkin backend
Development

No branches or pull requests
3 participants
@black-adder @yurishkuro @pavolloffay