Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of non-instrumented services #2628

Closed
yurishkuro opened this issue Nov 12, 2020 · 3 comments
Closed

Inclusion of non-instrumented services #2628

yurishkuro opened this issue Nov 12, 2020 · 3 comments

Comments

@yurishkuro
Copy link
Member

The other day we added the ability to render uninstrumented services that are referenced in the leaf spans via peer.service tag (jaegertracing/jaeger-ui#659).

This opens up a larger can of worms - should these services show up:

  • as pills in the trace row in the Search result?
  • in the Services dropdown on the Search page? And if they do, should the search bring back the traces that indirectly refer to those services?
  • in the service dependency graphs? (I always wanted them to)
@objectiser
Copy link
Contributor

as pills in the trace row in the Search result?

Yes, although presented slightly differently to make it clear not a traced service

in the Services dropdown on the Search page? And if they do, should the search bring back the traces that indirectly refer to those services?

Not sure about this one, as it would imply the other search criteria is applying to spans on that service, which is impossible as no spans exist

in the service dependency graphs? (I always wanted them to)

Yes, that would be good (again visually distinguished) - and also DDG.

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale The issue/PR has become stale and may be auto-closed label Jan 9, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Apr 16, 2022
@yurishkuro yurishkuro reopened this Apr 16, 2022
@stale stale bot removed the stale The issue/PR has become stale and may be auto-closed label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants