Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate lint tools to golangci-lint #2503

Closed
pavolloffay opened this issue Sep 22, 2020 · 5 comments
Closed

Migrate lint tools to golangci-lint #2503

pavolloffay opened this issue Sep 22, 2020 · 5 comments
Labels
help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@pavolloffay
Copy link
Member

Migrate go vet, staticcheck, gosec to https://golangci-lint.run/. It is a single tool that can run all static code analysis tools https://medium.com/wesionary-team/introduction-to-linters-in-go-and-know-about-golangci-lint-6486fb2864b3.

It's also used by the OTEL collector.
@ghost ghost added the needs-triage label Sep 22, 2020
@pavolloffay pavolloffay added help wanted Features that maintainers are willing to accept but do not have cycles to implement and removed needs-triage labels Sep 22, 2020
@yurishkuro
Copy link
Member

Looks good.

@eundoosong
Copy link
Contributor

Hello, I'd like to contribute on this

@pavolloffay
Copy link
Member Author

go for it @eundoosong

@yurishkuro
Copy link
Member

We also have a similar issue #538 to use gometalinter.

@yurishkuro yurishkuro mentioned this issue Oct 1, 2020
Merged
@daxmc99 daxmc99 mentioned this issue Oct 29, 2020
Closed
@eundoosong eundoosong removed their assignment Dec 1, 2020
@albertteoh albertteoh mentioned this issue Aug 29, 2021
Merged
@pavolloffay
Copy link
Member Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add golangci-lint daxmc99/jaeger
3 participants
@yurishkuro @pavolloffay @eundoosong