Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated --es.max-num-spans flag in v1.21.0 #2457

Closed
albertteoh opened this issue Sep 4, 2020 · 1 comment · Fixed by #2482
Closed

Remove deprecated --es.max-num-spans flag in v1.21.0 #2457

albertteoh opened this issue Sep 4, 2020 · 1 comment · Fixed by #2482
Labels
changelog:breaking-change Change that is breaking public APIs or established behavior good first issue Good for beginners
Milestone
Release 1.22.0

Comments

@albertteoh
Copy link
Contributor

Requirement - what kind of business use case are you trying to solve?

As a follow-up task to #2437, which deprecated --es.max-num-spans in favour of --es.max-doc-size, this is a reminder Issue to remove the deprecated --es.max-num-spans flag in version 1.21.0, as noted in the deprecation note on the flag.

Problem - what in Jaeger blocks you from solving the requirement?

Proposal - what do you suggest to solve the problem or improve the existing situation?

Any open questions to address
@ghost ghost added the needs-triage label Sep 4, 2020
@albertteoh albertteoh mentioned this issue Sep 4, 2020
Merged
@jpkrohling jpkrohling added this to the Release 1.21.0 milestone Sep 10, 2020
@jpkrohling jpkrohling added changelog:breaking-change Change that is breaking public APIs or established behavior good first issue Good for beginners hacktoberfest and removed needs-triage labels Sep 10, 2020
@BernardTolosajr
Copy link
Contributor

Hi guys, i'll pick this one. thanks

@BernardTolosajr BernardTolosajr mentioned this issue Sep 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:breaking-change Change that is breaking public APIs or established behavior good first issue Good for beginners
Projects
None yet
Milestone
Release 1.22.0
Development

Successfully merging a pull request may close this issue.

Remove deprecated es.max-num-spans BernardTolosajr/jaeger
4 participants
@jpkrohling @joe-elliott @BernardTolosajr @albertteoh