-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdout/stderr sync not implemented for gRPC storage plugins #2071
Comments
I don't think we can build anything special in Jaeger, we're fully delegating to go-plugin to start & manage the child process containing the plugin. See also hashicorp/go-plugin#113 (comment) |
@yurishkuro Makes sense. |
Jaeger is currently on go-plugin v1.0.1, but hashicorp/go-plugin#135 was released in v1.2, from what I understand. We can try upgrading. |
closing as we plan to sunset go-plugin based extensions #4647 |
Requirement - what kind of business use case are you trying to solve?
Need to propagate logs of a storage plugin gRPC server (implemented not in Go) to the OS stdout+stderr so that logs of the storage plugin can be analyzed.
Problem - what in Jaeger blocks you from solving the requirement?
go-plugin
doesn't sync stdout/stderr so there's no way to get the logs of the plugin (logging to file is not feasible in the environment)Proposal - what do you suggest to solve the problem or improve the existing situation?
I'm not a 100% sure how to fix it until go-plugin fixes in on their side, but figured maybe a workaround could be added in Jaeger because the relevant go-plugin issue doesn't seem to be getting a fix anytime soon:
hashicorp/go-plugin#93
Any open questions to address
N/A
The text was updated successfully, but these errors were encountered: