Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI arm64 support #1973

Closed
jishminor opened this issue Dec 10, 2019 · 9 comments
Closed

Travis CI arm64 support #1973

jishminor opened this issue Dec 10, 2019 · 9 comments

Comments

@jishminor
Copy link

Requirement - what kind of business use case are you trying to solve?

Run and test all Jaeger components on arm64.

Problem - what in Jaeger blocks you from solving the requirement?

No existing infrastructure to build and test Jaeger components on arm64.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Travis CI can now run multiarch builds out of the box: https://docs.travis-ci.com/user/multi-cpu-architectures/.

Any open questions to address

Would there be any interest in modifying the CI configuration to support arm64 builds?

@yurishkuro
Copy link
Member

I'd be concerned with how much extra load it would add to our CI jobs, which already take quite a while to run for each PR.

@jpkrohling
Copy link
Contributor

I think we could consider adding it at least for the unit tests. I think it would cover most of the arch-related issues that we might face.

@jishminor
Copy link
Author

jishminor commented Dec 11, 2019

Pushing the arm64 docker images to dockerhub would also be a great addition. Especially with the announcement of bigger and better AWS arm64 ec2 instances: https://aws.amazon.com/blogs/aws/coming-soon-graviton2-powered-general-purpose-compute-optimized-memory-optimized-ec2-instances/.

@jpkrohling
Copy link
Contributor

@jishminor are you able to commit to support this when it needs maintenance? If so, send a PR with your proposal and let's see how the CI gets affected.

@jishminor
Copy link
Author

I have only so far been using an arm64 jaeger agent, which speaks to a x86 jaeger collector. I still need to fully familiarize myself with your build and test infrastructure before I can give my commitment for maintenance support for arm64. Let me do some experimenting and get back to you. I don't for-see many things breaking when swapping out the x86 go runtime for the arm64, besides any OS level package use (syscall interfaces etc).

@jpkrohling
Copy link
Contributor

Let us know if you hit any roadblocks!

@vielmetti
Copy link

@jishminor have you had any success here? If you need arm64 infrastructure to test or develop, reach out to the @WorksOnArm project via opening an issue at https://github.com/worksonarm/cluster/issues .

@jishminor
Copy link
Author

@vielmetti I have not yet. I have my own repository for the Jaeger Agent on arm64 and arm, but have not gotten around to playing with the build infrastructure in this repo.

@yurishkuro
Copy link
Member

ARM64 binaries are already supported (#1656) as part of the release (but not the Docker images).

We don't have the CI resources to do integration testing on all supported platforms. I am closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants