Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jaeger-debug-id header even when there is an established trace context #165

Closed
2 tasks
yurishkuro opened this issue May 15, 2017 · 3 comments
Closed
2 tasks
Labels
help wanted Features that maintainers are willing to accept but do not have cycles to implement meta-issue An tracking issue that requires work in other repos

Comments

@yurishkuro
Copy link
Member

Some command line tools like yab are capable of starting a trace before sending the request. They also allow setting additional headers like jaeger-debug-id, but the Jaeger client libs ignore (at least Java client does) it since there is already a trace context.

  • make sure all clients respect the header regardless of the presence of the trace
  • add a test for this behavior to end-to-end test
@yurishkuro yurishkuro added the help wanted Features that maintainers are willing to accept but do not have cycles to implement label May 15, 2017
@vprithvi
Copy link
Contributor

vprithvi commented May 15, 2017

This is true of the node client as well.
Additionally, we should test that the trace id/span id in the trace context isn't mutated by application of jaeger-debug-id

@rbtcollins
Copy link
Contributor

I suspect this is true of the c++ client too since our nginx stack seems to be ignoring the header.

@yurishkuro
Copy link
Member Author

Per #3362, we're sunsetting Jaeger clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Features that maintainers are willing to accept but do not have cycles to implement meta-issue An tracking issue that requires work in other repos
Projects
None yet
Development

No branches or pull requests

4 participants