Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode gRPC logs with zap and emit to stdout #1602

Closed
vprithvi opened this issue Jun 13, 2019 · 2 comments · Fixed by #1606
Closed

Encode gRPC logs with zap and emit to stdout #1602

vprithvi opened this issue Jun 13, 2019 · 2 comments · Fixed by #1606

Comments

@vprithvi
Copy link
Contributor

Requirement - what kind of business use case are you trying to solve?

It appears that gRPC logs are not json formatted, which implies that they are not using zap

Proposal - what do you suggest to solve the problem or improve the existing situation?

Use zap and emit grpc logs to stdout

@yurishkuro
Copy link
Member

grpc uses its own logging API, that needs to be wrapped to work with zap.

we can probably use this: https://github.com/grpc-ecosystem/go-grpc-middleware/blob/master/logging/zap/doc.go

@yurishkuro
Copy link
Member

There's a PR #1330 trying to address this, but it needs rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants