-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize span detail components #64
Merged
Merged
Commits on Aug 11, 2017
-
Configuration menu - View commit details
-
Copy full SHA for fe35bbd - Browse repository at this point
Copy the full SHA fe35bbdView commit details -
WIP commit for refactoring trace detail view
TODO - Test are currently in a bad state - Finish shifting to transformed trace, exclusively, instead of raw trace - Misc cleanup (unused / ordering of vars, imports, etc) is outstanding while changes are WIP - Continued refinement of trace-detail components, selectors and utils - Many styles will be moved to CSS - Will likely remove `model/trace-viewer.js` SpanGraph - Fix #49 - Span position in graph doesn not match its position in the detail - Ticks in span graph made to match trace detail (in number and formatting) - Span graph refactored to trim down files and DOM elements TracePageHeader - `trace` prop removed - Added props for various title values instead of deriving them from `trace` Trace Detail - Several components split out into separate files - `transformTrace` to use alread span tree to determine span depth Span Detail - Fix uber/jaeger #326: extraneous scrollbars in trace views - Fix: Some tags were not being rendered due to clashing keys (observed in a log message) - Tall content scrolls via entire table instead of single table cell - Horizontal scrolling for wide content (e.g. long log values) - Full width of the header is clickable for tags, process, and logs headers (instead of header text, only) - Service and endpoint are shown on mouseover anywhere in span bar row Misc - Several TraceTimelineViewer / utils removed - `TreeNode` `.walk()` method can now be used to calculate the depth, avoiding use of less efficient `.getPath()` - Removed several `console.error` warnings caused by React key issues
Configuration menu - View commit details
-
Copy full SHA for acbfdee - Browse repository at this point
Copy the full SHA acbfdeeView commit details
Commits on Aug 14, 2017
-
WIP commit for refactoring trace detail view
TODO - Test are currently in a bad state - Finish shifting to transformed trace, exclusively, instead of raw trace - Misc cleanup (unused / ordering of vars, imports, etc) is outstanding while changes are WIP - Continued refinement of trace-detail components, selectors and utils - Many styles will be moved to CSS - Will likely remove `model/trace-viewer.js` Span Bar / Detail - Label on span bars no longer off-screen - Clip or hide span bars when zoomed in (insted of flush left) - Add shadow to left / right boundary when span bar view is clipped - Darkened span name column to differentiate from span bar section - Span detail left column color coded by service - Clicking span detail left column collapses detail - Clicking anywhere left of parent span name toggles children visibility
Configuration menu - View commit details
-
Copy full SHA for 4fa5c8a - Browse repository at this point
Copy the full SHA 4fa5c8aView commit details
Commits on Aug 17, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 93a6fb7 - Browse repository at this point
Copy the full SHA 93a6fb7View commit details
Commits on Aug 20, 2017
-
Configuration menu - View commit details
-
Copy full SHA for b8945ab - Browse repository at this point
Copy the full SHA b8945abView commit details -
WIP refactor trace, yarn upgrade
Sub-page scrolling used for trace detail (TODO: revert this). This lays the ground work for using react-virtualized, but unfortunately has major perf issues, hence the TODO: revert. yarn upgrade --latest. Notable changes: - Removed react-sticky - react-router v4 - react-vis CSS needed to be included via a sym-link Misc tweaks: - Styling adjusted on trace mini-map - Scatterplot dots are sized based on number of spans - Scatterplot dots mouseover shows trace name
Configuration menu - View commit details
-
Copy full SHA for 401b083 - Browse repository at this point
Copy the full SHA 401b083View commit details -
Configuration menu - View commit details
-
Copy full SHA for c34bbd3 - Browse repository at this point
Copy the full SHA c34bbd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c041353 - Browse repository at this point
Copy the full SHA c041353View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f54454 - Browse repository at this point
Copy the full SHA 9f54454View commit details -
Configuration menu - View commit details
-
Copy full SHA for c657cf1 - Browse repository at this point
Copy the full SHA c657cf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2226744 - Browse repository at this point
Copy the full SHA 2226744View commit details -
Configuration menu - View commit details
-
Copy full SHA for f555e8b - Browse repository at this point
Copy the full SHA f555e8bView commit details
Commits on Aug 21, 2017
-
Configuration menu - View commit details
-
Copy full SHA for bef7f5b - Browse repository at this point
Copy the full SHA bef7f5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa6f016 - Browse repository at this point
Copy the full SHA fa6f016View commit details -
Fix unreleased regression - ellipsis on span name
Add back the styling that adds an ellipsis to truncated span name text.
Configuration menu - View commit details
-
Copy full SHA for 3797f5b - Browse repository at this point
Copy the full SHA 3797f5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fd43f5 - Browse repository at this point
Copy the full SHA 0fd43f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 542c1ba - Browse repository at this point
Copy the full SHA 542c1baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42736e0 - Browse repository at this point
Copy the full SHA 42736e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d16097b - Browse repository at this point
Copy the full SHA d16097bView commit details
Commits on Aug 22, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 83b28d5 - Browse repository at this point
Copy the full SHA 83b28d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdd6d7e - Browse repository at this point
Copy the full SHA bdd6d7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7204684 - Browse repository at this point
Copy the full SHA 7204684View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bdf8b6 - Browse repository at this point
Copy the full SHA 9bdf8b6View commit details
Commits on Aug 24, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 0113985 - Browse repository at this point
Copy the full SHA 0113985View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c7f896 - Browse repository at this point
Copy the full SHA 5c7f896View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.