Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize span detail components #64

Merged
merged 25 commits into from
Aug 25, 2017
Merged

Reorganize span detail components #64

merged 25 commits into from
Aug 25, 2017

Commits on Aug 11, 2017

  1. Configuration menu
    Copy the full SHA
    fe35bbd View commit details
    Browse the repository at this point in the history
  2. WIP commit for refactoring trace detail view

    TODO
    - Test are currently in a bad state
    - Finish shifting to transformed trace, exclusively, instead of raw
      trace
    - Misc cleanup (unused / ordering of vars, imports, etc) is outstanding
      while changes are WIP
    - Continued refinement of trace-detail components, selectors and utils
    - Many styles will be moved to CSS
    - Will likely remove `model/trace-viewer.js`
    
    SpanGraph
    
    - Fix #49 - Span position in graph doesn not match its position in the
      detail
    - Ticks in span graph made to match trace detail (in number and
      formatting)
    - Span graph refactored to trim down files and DOM elements
    
    TracePageHeader
    
    - `trace` prop removed
    - Added props for various title values instead of deriving them
      from `trace`
    
    Trace Detail
    
    - Several components split out into separate files
    - `transformTrace` to use alread span tree to determine span depth
    
    Span Detail
    
    - Fix uber/jaeger #326: extraneous scrollbars in trace views
    - Fix: Some tags were not being rendered due to clashing keys (observed
      in a log message)
    - Tall content scrolls via entire table instead of single table cell
    - Horizontal scrolling for wide content (e.g. long log values)
    - Full width of the header is clickable for tags, process, and logs
      headers (instead of header text, only)
    - Service and endpoint are shown on mouseover anywhere in span bar row
    
    Misc
    - Several TraceTimelineViewer / utils removed
    - `TreeNode` `.walk()` method can now be used to calculate the depth,
      avoiding use of less efficient `.getPath()`
    - Removed several `console.error` warnings caused by React key issues
    tiffon committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    acbfdee View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2017

  1. WIP commit for refactoring trace detail view

    TODO
    - Test are currently in a bad state
    - Finish shifting to transformed trace, exclusively, instead of raw
      trace
    - Misc cleanup (unused / ordering of vars, imports, etc) is outstanding
      while changes are WIP
    - Continued refinement of trace-detail components, selectors and utils
    - Many styles will be moved to CSS
    - Will likely remove `model/trace-viewer.js`
    
    Span Bar / Detail
    - Label on span bars no longer off-screen
    - Clip or hide span bars when zoomed in (insted of flush left)
    - Add shadow to left / right boundary when span bar view is clipped
    - Darkened span name column to differentiate from span bar section
    - Span detail left column color coded by service
    - Clicking span detail left column collapses detail
    - Clicking anywhere left of parent span name toggles children
      visibility
    tiffon committed Aug 14, 2017
    Configuration menu
    Copy the full SHA
    4fa5c8a View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2017

  1. Configuration menu
    Copy the full SHA
    93a6fb7 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2017

  1. Configuration menu
    Copy the full SHA
    b8945ab View commit details
    Browse the repository at this point in the history
  2. WIP refactor trace, yarn upgrade

    Sub-page scrolling used for trace detail (TODO: revert this). This lays
    the ground work for using react-virtualized, but unfortunately has major
    perf issues, hence the TODO: revert.
    
    yarn upgrade --latest. Notable changes:
    
    - Removed react-sticky
    - react-router v4
    - react-vis CSS needed to be included via a sym-link
    
    Misc tweaks:
    
    - Styling adjusted on trace mini-map
    - Scatterplot dots are sized based on number of spans
    - Scatterplot dots mouseover shows trace name
    tiffon committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    401b083 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c34bbd3 View commit details
    Browse the repository at this point in the history
  4. remove unused import

    tiffon committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    c041353 View commit details
    Browse the repository at this point in the history
  5. add license to css files

    tiffon committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    9f54454 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c657cf1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2226744 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f555e8b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2017

  1. Add comments to new utils

    tiffon committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    bef7f5b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa6f016 View commit details
    Browse the repository at this point in the history
  3. Fix unreleased regression - ellipsis on span name

    Add back the styling that adds an ellipsis to truncated span name text.
    tiffon committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    3797f5b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0fd43f5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    542c1ba View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    42736e0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d16097b View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2017

  1. Configuration menu
    Copy the full SHA
    83b28d5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bdd6d7e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7204684 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9bdf8b6 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2017

  1. Configuration menu
    Copy the full SHA
    0113985 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5c7f896 View commit details
    Browse the repository at this point in the history