Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move filter to query param and highlight filter matches on graphs #310

Commits on Jan 16, 2019

  1. Add a TraceGraph view (jaegertracing#273) (jaegertracing#276)

    Add alternative view in TracePage which allows
    to see count, avg. time, total time and self time for
    a given trace grouped by service and operation.
    
    Signed-off-by: Patrick Coray <[email protected]>
    Signed-off-by: Everett Ross <[email protected]>
    copa2 authored and everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    bdc0220 View commit details
    Browse the repository at this point in the history
  2. Revisions for search and trace detail embed mode (jaegertracing#286)

    * Misc tweaks for search and trace detail embed mode
    
    Mostly from prior comments.
    
    - Rename query parameter for embedding to start with "ui" and use the
      page as the first word, e.g. "uiSearchHideGraph"
    
    - Change query parameters for the minimap and trace details from hiding
      to showing, e.g. "hidemap" -> "uiTimelineShowMap"
    
    - Save the embed query params in Redux state instead of passing them
      around
    
    - Use a Link with an icon instead of text buttons for opening the
      standalone view of the page
    
    - Propagate whether the trace detail page is from the search page or
      not via the Location#state member on the React Router Location
    
    - When returning to the search page use the previous results instead
      of executing a new search. This is done by storing the query with
      the search results.
    
    - Adjusted aesthetic of "Back to Search" button on trace detail page
    
    - Sequester parsing and stripping query parameters for the embed mode
      to a util
    
    - In various places switch to using the component/*/url.js#getUrl
      functions instead of prefixUrl(...)
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * Fix test break from merging master
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * Keep redux search query synced with results
    
    - Keep redux search query synced with redux search result (and their
      processing). Also fixes jaegertracing#288.
    
    - Bolster unit tests
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * Fix typo
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * Make TracePageHeader collapsible when embedded
    
    - Reconfigured embed query parameters for timeline:
    
      - uiTimelineCollapseTitle=1 - TracePageHeader starts out collapsed
    
      - uiTimelineHideMinimap=1 - TracePageHeader does not show the minimap
    
      - uiTimelineHideSummary=1 - TracePageHeader does not show the trace
        summary
    
    - Consolidate TracePageHeader and TracePageHeaderEmbed
    
    - Style changes to TracePageHeader
    
    - Embedded TracePageHeader can now be expanded and collapsed
    
    - Misc cleanup in TracePageHeader
    
    - Better comparisons for search page query to prevent re-fetching
      when returning to the search page
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * Fix typo disableComparisions
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * Use public registry to newly installed packages
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * Test improvements
    
    Signed-off-by: Joe Farro <[email protected]>
    Signed-off-by: Everett Ross <[email protected]>
    tiffon authored and everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    4112482 View commit details
    Browse the repository at this point in the history
  3. Unfocus unit test (jaegertracing#298)

    Signed-off-by: Joe Farro <[email protected]>
    Signed-off-by: Everett Ross <[email protected]>
    tiffon authored and everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    2baf075 View commit details
    Browse the repository at this point in the history
  4. Add a Button to Reset Viewing Layer Zoom (jaegertracing#215) (jaegert…

    …racing#290)
    
    * Add button to reset viewing layer zoom (jaegertracing#215)
    
    Signed-off-by: Everett Ross <[email protected]>
    
    * Adhere to className pattern, sort imports, remove event handling
    
    Signed-off-by: Everett Ross <[email protected]>
    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    d90d042 View commit details
    Browse the repository at this point in the history
  5. Add a copy icon to entries in KeyValuesTable (jaegertracing#204) (jae…

    …gertracing#292)
    
    * Add a copy icon to entries in KeyValuesTable (jaegertracing#204)
    
    Signed-off-by: Everett Ross <[email protected]>
    
    * Add a tooltip to copy icon in KeyValuesTable
    
    Signed-off-by: Everett Ross <[email protected]>
    
    * Fix copied test name, add test for KeyValuesTable state change on tooltip hide
    
    Signed-off-by: Everett Ross <[email protected]>
    
    * Add eslint rule to prevent unnecessary braces in jsx
    
    Signed-off-by: Everett Ross <[email protected]>
    
    * Add classname to tr to remove element selector, fix yarn.lock
    
    Signed-off-by: Everett Ross <[email protected]>
    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    29b340d View commit details
    Browse the repository at this point in the history
  6. Add popover and prevent submit if duration params are invalid (jaeger…

    …tracing#244) (jaegertracing#291)
    
    * Add validation for duration fields in SearchForm (jaegertracing#244)
    
    Signed-off-by: Everett Ross <[email protected]>
    
    * Add tests for redux-form-field-adapter
    
    Signed-off-by: Everett Ross <[email protected]>
    
    * Fix boolean prop type
    
    Signed-off-by: Everett Ross <[email protected]>
    
    * Add boolean for input validation, change popover to show when inactive
    
    Signed-off-by: Everett Ross <[email protected]>
    
    * Add tests for onChangeAdapter
    
    Signed-off-by: Everett Ross <[email protected]>
    
    * Create separate ValidatedAdaptedInput for duration fields
    
    Signed-off-by: Everett Ross <[email protected]>
    
    * Remove unnecessary curly braces
    
    Signed-off-by: Everett Ross <[email protected]>
    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    e0f34e4 View commit details
    Browse the repository at this point in the history
  7. Add indent guides to trace timeline view (jaegertracing#172) (jaegert…

    …racing#297)
    
    * Add indent guides to trace timeline view (jaegertracing#172)
    
    Signed-off-by: Everett Ross <[email protected]>
    
    * Add tests for connect functions, add more flow types
    
    Signed-off-by: Everett Ross <[email protected]>
    
    * Consolidate ducks, remove redudant PropTypes, add event type
    
    Signed-off-by: Everett Ross <[email protected]>
    
    * Rename hoverSpanId to hoverIndentGuideId
    
    Signed-off-by: Everett Ross <[email protected]>
    
    * Derive props from span, use dataset over getAttribute
    
    Signed-off-by: Everett Ross <[email protected]>
    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    bf70c14 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    07c7f4f View commit details
    Browse the repository at this point in the history
  9. Style GraphSearch, Debounce query param updating

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    1953db5 View commit details
    Browse the repository at this point in the history
  10. Use hex instead of html colors, remove commented code

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    e918deb View commit details
    Browse the repository at this point in the history
  11. Handle falsy graphSearch value in state, improve typing

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    181562c View commit details
    Browse the repository at this point in the history
  12. Move GraphSearch and use as utility

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    edf4805 View commit details
    Browse the repository at this point in the history
  13. Add tests for GraphSearch

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    d1e05d6 View commit details
    Browse the repository at this point in the history
  14. Update create-react-app to 2.1.2 (jaegertracing#302)

    * WIP upgrade to create-react-app v2.1.2
    
    Requires changes from PR jaegertracing#346 which are published as
    [email protected]
    
    timarney/react-app-rewired#346
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * Use node 8, less liberal browser support, fix test
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * Use eslintrc, fix CI build, fix pre-commit hook
    
    Make sure the ./packages/jaeger-ui uses the ./.eslintrc.
    
    Make sure all tests are run in pre-commit hook.
    
    CRA is now failing builds in CI if there are any webpack build warnings:
    
    https://github.com/facebook/create-react-app/blob/73e3d0ebf1f2834e1c8c41d3a25ae5e0e99e6f14/packages/react-scripts/scripts/build.js#L171-L184
    Signed-off-by: Joe Farro <[email protected]>
    
    * Skip react-vis.css format check, fail-fast in CI
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * Don't collect coverage from dev proxy setup
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * Upgrade react-app-rewired to 2.0.1
    
    Avoid issue yarnpkg/yarn#6300
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * Cleanup npm packages in packages/jaeger-ui
    
    Signed-off-by: Joe Farro <[email protected]>
    Signed-off-by: Everett Ross <[email protected]>
    tiffon authored and everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    6ea7d6a View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    5fa907b View commit details
    Browse the repository at this point in the history
  16. Improve spy variable name

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    0122fd7 View commit details
    Browse the repository at this point in the history
  17. Ability to open additional menu links in same tab (Resolves jaegertra…

    …cing#275) (jaegertracing#278)
    
    * Ability to open additional menu links in same tab (jaegertracing#275)
    
    Signed-off-by: Vitaliy Zabolotskyy <[email protected]>
    
    * Add negative test case
    
    Signed-off-by: Vitaliy Zabolotskyy <[email protected]>
    
    * Add helper function to create item links
    
    Signed-off-by: Vitaliy Zabolotskyy <[email protected]>
    
    * Fix no-use-before-define lint error
    
    Signed-off-by: Vitaliy Zabolotskyy <[email protected]>
    
    * Use anchorTarget in custom menu configuration
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * Fix typo in test case
    
    Signed-off-by: Joe Farro <[email protected]>
    Signed-off-by: Everett Ross <[email protected]>
    zablvit authored and everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    f08a609 View commit details
    Browse the repository at this point in the history
  18. Revive the changelog (jaegertracing#300)

    * Revive the changelog
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * Add helper script to generate CHANGELOG entries
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * One more changelog item, fix date typo
    
    Signed-off-by: Joe Farro <[email protected]>
    
    * Fix phrasing in changelog
    
    Signed-off-by: Joe Farro <[email protected]>
    Signed-off-by: Everett Ross <[email protected]>
    tiffon authored and everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    8e2df85 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    7ea05f4 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    2bf1b43 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    353d69c View commit details
    Browse the repository at this point in the history
  22. Update exisitng test files

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    99b7a6c View commit details
    Browse the repository at this point in the history
  23. Polish filter-spans

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    10b5194 View commit details
    Browse the repository at this point in the history
  24. Merge branch 'jaegertracingmaster' into issue-307-add-node-search-to-…

    …tracegraph-and-tracediffgraph
    
    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    dd9f14c View commit details
    Browse the repository at this point in the history
  25. Use uppercase types, remove constructor for initial state

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    0c5b591 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2019

  1. Configuration menu
    Copy the full SHA
    50db264 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'jaegertracingmaster' into issue-307-add-node-search-to-…

    …tracegraph-and-tracediffgraph
    
    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    9a7e0c1 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'issue-307-add-node-search-to-tracegraph-and-tracediffgr…

    …aph' into issue-239-fix-TracePageHeader-tests-once-new-version-of-enzyme-is-released
    
    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    ef880c7 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. Add tests to TraceDiff/

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    e531d6e View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. Configuration menu
    Copy the full SHA
    fe420c6 View commit details
    Browse the repository at this point in the history
  2. Fix node/edge layering, simplify ui-find-match css

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    a5178e0 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2019

  1. Change diffNode ui match color, scale ui match outline size

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    66f080d View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2019

  1. Calculate box-shadow size on nodesContainer not drawNode

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    9dc1a4e View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2019

  1. Fix color attributes to preserve node text color

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    f685d47 View commit details
    Browse the repository at this point in the history
  2. Rename UIFind to UiFind, Update TraceDiffFind

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    b6b40c0 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2019

  1. Finish DiffGraph find css, Render 0 count suffix

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    acd3e66 View commit details
    Browse the repository at this point in the history
  2. merge master and update test

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    2434056 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2019

  1. Fix git case insensitivity issue

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    51337fb View commit details
    Browse the repository at this point in the history
  2. Merge branch 'issue-307-add-node-search-to-tracegraph-and-tracediffgr…

    …aph' into issue-239-fix-TracePageHeader-tests-once-new-version-of-enzyme-is-released
    everett980 committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    4313988 View commit details
    Browse the repository at this point in the history
  3. Merge updated graph find, maintain increased test coverage

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    1f5421d View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2019

  1. Configuration menu
    Copy the full SHA
    69a576a View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. Clean up WIP commit

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    259cd13 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    15c51d5 View commit details
    Browse the repository at this point in the history
  3. Ensure scroll to bottom scrolls to last visible span

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    a1f5e59 View commit details
    Browse the repository at this point in the history
  4. Move addToUiFind logic to VirtualizedTraceView

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    aa3f2e5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    df9bafd View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2019

  1. Merge branch 'issue-307-add-node-search-to-tracegraph-and-tracediffgr…

    …aph' into issue-239-fix-TracePageHeader-tests-once-new-version-of-enzyme-is-released
    everett980 authored Mar 6, 2019
    Configuration menu
    Copy the full SHA
    7422720 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2019

  1. Process FOLLOWS_FROM spans in TraceView (jaegertracing#335)

    * Process FOLLOWS_FROM spans in TraceView
    
    Signed-off-by: Ruben Vargas <[email protected]>
    
    * Add test for FOLLOWS_FROM span relation for SpanTreeOffset
    
    Signed-off-by: Ruben Vargas <[email protected]>
    rubenvp8510 authored and everett980 committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    c5034fa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    95026f9 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2019

  1. fix merge again

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    c3d4d14 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'issue-307-add-node-search-to-tracegraph-and-tracediffgr…

    …aph' into issue-239-fix-TracePageHeader-tests-once-new-version-of-enzyme-is-released
    everett980 committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    bf3386f View commit details
    Browse the repository at this point in the history
  3. Update tests after merge

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    b4afe2d View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1 from everett980/issue-239-fix-TracePageHeader-t…

    …ests-once-new-version-of-enzyme-is-released
    
    Update enzyme, Re-enable and add TraceDiff and TracePage tests
    everett980 authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    de6571f View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. Clean up and DRY out tests, Change trackFilter to function

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    5386868 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'jaegertracingmaster' into issue-307-add-node-search-to-…

    …tracegraph-and-tracediffgraph
    everett980 committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    5971072 View commit details
    Browse the repository at this point in the history
  3. Fix yarn.lock urls

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    c5f40c8 View commit details
    Browse the repository at this point in the history
  4. Fix yarn.lock change %2f back to /

    Signed-off-by: Everett Ross <[email protected]>
    everett980 committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    8a4b0fb View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2019

  1. Configuration menu
    Copy the full SHA
    d3965dc View commit details
    Browse the repository at this point in the history