Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic analytics tracking (in addition to GA) #652

Closed
yoave23 opened this issue Oct 11, 2020 · 5 comments · Fixed by #681
Closed

generic analytics tracking (in addition to GA) #652

yoave23 opened this issue Oct 11, 2020 · 5 comments · Fixed by #681

Comments

@yoave23
Copy link
Contributor

yoave23 commented Oct 11, 2020

Requirement - what kind of business use case are you trying to solve?

We would like to be able to track events in a generic way (i.e with a non GA solution) when running jaeger-UI inside an iframe

Problem - what in Jaeger blocks you from solving the requirement?

Jaeger-UI tracking is tightly coupled to GA

Proposal - what do you suggest to solve the problem or improve the existing situation?

We were thinking about adding a post message to the tracking flow so it would be possible to register for events invoked by the UI.
the new flow will be configurable via the UI-config file

Any open questions to address

@yurishkuro
Copy link
Member

Is it really tightly coupled to GA? My impression was that there is a thin abstraction in the code used to report events, and that abstraction is bound to the GA by default. If that's the case, then extending it to be bound to another function / library seems reasonable.

The only issue is that the UI config is currently a JSON file, whereas we discussed (#123) that it would be better to make it a JS file to allow defining functions, not just const values.

@yoave23
Copy link
Contributor Author

yoave23 commented Oct 13, 2020

@yurishkuro maybe tightly coupled isn't the correct term, but GA is currently the only way to report the tracked UI events, and this issue (feature suggestion) does aim to extend it.

Regarding #123, I believe that changing the UI config to a js file would mean a breaking change.
Also, could you please elaborate a little on the actual benefit of having a js file for configuring the UI (besides the ability to add comments)?

@yurishkuro
Copy link
Member

this issue (feature suggestion) does aim to extend it.

+1

changing the UI config to a js file would mean a breaking change

No, we can still support JSON file as well and make the change backward compatible.

could you please elaborate a little on the actual benefit of having a js file for configuring the UI

A JS file allows you to customize UI with functions. For example, in case of tracking, assume we have an API like RecordEvent(...). By default it is implemented via GA lib, but in the config file you could provide a different implementation, either fully embedded into the config file, or by referencing additional JS modules.

@th3M1ke
Copy link
Contributor

th3M1ke commented Jan 20, 2021

@yurishkuro can I take this one?

@yurishkuro
Copy link
Member

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants