Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Results DDG Paths should be deduped #503

Closed
everett980 opened this issue Dec 19, 2019 · 0 comments · Fixed by #558
Closed

Search Results DDG Paths should be deduped #503

everett980 opened this issue Dec 19, 2019 · 0 comments · Fixed by #558

Comments

@everett980
Copy link
Collaborator

Requirement - what kind of business use case are you trying to solve?

Performance and ability to encode visibility when viewing many / large traces.

Problem - what in Jaeger blocks you from solving the requirement?

Paths are not deduped in model/ddg/transformTracesToPaths which causes an unnecessary number of PathElems which hinders performance.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Before adding a path to the result, hash it and check if the path was already created from these traces. If not, add to result and a map. If so, get path from map and add traceID to exemplars (if not yet present in exemplars).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant