-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Adding Config for TotalMemory in LayoutManager for TraceGraph #1249
Labels
Comments
+1 |
yurishkuro
pushed a commit
that referenced
this issue
Mar 14, 2023
Trace graph has a problem to renders large traces (with ~15K+ spans), and gives the error "Cannot enlarge memory arrays". Need to give users flexibility to control the totalMemory of LayoutManager used for TraceGraph. <!-- Please delete this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 Before creating a pull request, please make sure: - Your PR is solving one problem - You have read the guide for contributing - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING.md - You signed all your commits (otherwise we won't be able to merge the PR) - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md#certificate-of-origin---sign-your-work - You added unit tests for the new functionality - You mention in the PR description which issue it is addressing, e.g. "Resolves #123" --> ## Which problem is this PR solving? - Resolves #1249 ## Short description of the changes Trace graph has a problem to renders large traces (with ~15K+ spans), and gives the error "Cannot enlarge memory arrays". This can be fixed by providing a larger number of memory when initializing the `LayoutManager` in trace graph, like below: ``` // default 16MB this.layoutManager = new LayoutManager({ totalMemory: 33554432, useDotEdges: true, splines: 'polyline' }); ``` But instead of hardcoding the memory value in code, we want to give users the flexibility to control the totalMemory of LayoutManager for TraceGraph. Signed-off-by: Chen Xu <[email protected]>
Binrix
pushed a commit
to Binrix/jaeger-ui
that referenced
this issue
Apr 18, 2023
Trace graph has a problem to renders large traces (with ~15K+ spans), and gives the error "Cannot enlarge memory arrays". Need to give users flexibility to control the totalMemory of LayoutManager used for TraceGraph. <!-- Please delete this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 Before creating a pull request, please make sure: - Your PR is solving one problem - You have read the guide for contributing - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING.md - You signed all your commits (otherwise we won't be able to merge the PR) - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md#certificate-of-origin---sign-your-work - You added unit tests for the new functionality - You mention in the PR description which issue it is addressing, e.g. "Resolves jaegertracing#123" --> - Resolves jaegertracing#1249 Trace graph has a problem to renders large traces (with ~15K+ spans), and gives the error "Cannot enlarge memory arrays". This can be fixed by providing a larger number of memory when initializing the `LayoutManager` in trace graph, like below: ``` // default 16MB this.layoutManager = new LayoutManager({ totalMemory: 33554432, useDotEdges: true, splines: 'polyline' }); ``` But instead of hardcoding the memory value in code, we want to give users the flexibility to control the totalMemory of LayoutManager for TraceGraph. Signed-off-by: Chen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Requirement
As a Jaeger operator,
I want to have
TotalMemory
option in config so that we have the flexibility to tune it for trace graph with large trace (15K+ spans).Problem
Today, we face the issue that the trace graph doesn't show up for large traces (with ~15K+ spans).
Error message:
I think the reason is the allocated memory for viz is not enough.
So when I provided a larger number for memory like below in code here, then the trace graph can show up successfully.
Proposal
I can fix by provide a large
totalMemory
when initializingLayoutManager
for trace graph, but I don't think hardcode the value in the code (TraceGraph.tsx) is a good way, and default value is good enough for most use cases.So I would like to have
totalMemory
exposed in the config, so that anyone has the flexibility to tune thetotalMemory
themselves if needed.Like:
If this proposal is ok with you, I can implement it and submit a PR.
Open questions
No response
The text was updated successfully, but these errors were encountered: