Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose version or commit SHA of UI #113

Closed
tiffon opened this issue Oct 31, 2017 · 5 comments
Closed

Expose version or commit SHA of UI #113

tiffon opened this issue Oct 31, 2017 · 5 comments

Comments

@tiffon
Copy link
Member

tiffon commented Oct 31, 2017

Purpose is to be able to determine which version of the UI is currently deployed.

If version is used, it needs to not always be 0.0.1.

Thanks to @saminzadeh for suggesting this.

@yurishkuro
Copy link
Member

+1. Is there an npm module that can extract the commit during the build?

@tiffon
Copy link
Member Author

tiffon commented Nov 28, 2017

It would also be nice for this to show the version of the Jaeger services, not just the UI.

Related jaegertracing/jaeger#145

@tiffon
Copy link
Member Author

tiffon commented Nov 28, 2017

@yurishkuro Re npm package, we might be able to use git-repo-version to generate (package-version, SHA, date) strings and jest-changed-files to capture which files, if any, have been modified for the build.

git-repo-version: 1.5.0+a1b2c3d4e5 2016-10-24T18:26:53.000Z

jest-changed-files:

import {getChangedFilesForRoots} from 'jest-changed-files';

getChangedFilesForRoots(['/path/to/test'], {
  lastCommit: true,
  withAncestor: true,
}).then(files => {
  /*
  {
    repos: [],
    changedFiles: []
  }
  */
});

@yurishkuro
Copy link
Member

during the build we can easily get the SHAs for both query service and the ui submodule using git commands directly. The UI build could read them from env vars.

@yurishkuro
Copy link
Member

Resolved by #606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants