Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that --config-file shouldn't be used with the operator #84

Closed
jpkrohling opened this issue Nov 5, 2018 · 2 comments
Closed
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@jpkrohling
Copy link
Contributor

Using an external configuration file mean that the Jaeger instance has to be manually restarted, instead of letting the operator handle the configuration change.

We need to document this behavior and recommendation, but also point out that this might change soon, once on-the-fly updates are supported.

See jaegertracing/jaeger#1058

@jpkrohling jpkrohling added enhancement New feature or request good first issue Good for newcomers labels Nov 5, 2018
@jpkrohling jpkrohling added needs-triage New issues, in need of classification and removed needs-triage New issues, in need of classification labels Dec 16, 2019
@yurishkuro
Copy link
Member

@jpkrohling do we still need this given that #2188 implements time-based reloading?

@jpkrohling
Copy link
Contributor Author

Good question. I think the basic idea is still valid ("a config file shouldn't be used with the operator"), as the Operator will add configuration options as flags based on the environment (mTLS when possible, ES URL for auto-provisioned storage, ...) and using --config-file might cause confusion when trying to figure out the effective configuration for an instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants