Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable operator user to specify sampling strategies #83

Closed
objectiser opened this issue Nov 5, 2018 · 1 comment
Closed

Enable operator user to specify sampling strategies #83

objectiser opened this issue Nov 5, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@objectiser
Copy link
Contributor

As described here, it is possible to specify adaptive sampling strategy details in a json file.

As changes to the sampling strategies may be automatically reloaded when changed, it may be appropriate to create this mounted file as default (albeit empty) - so an update to just this part of a CR does not need to necessarily cause the restarted.

We should consider in general what the update approach should be when changes are applied to the CR. Maybe a general rolling update approach would be safer.

@jpkrohling
Copy link
Contributor

As changes to the sampling strategies may be automatically reloaded when changed, it may be appropriate to create this mounted file as default (albeit empty) - so an update to just this part of a CR does not need to necessarily cause the restarted.

+1

We should consider in general what the update approach should be when changes are applied to the CR. Maybe a general rolling update approach would be safer.

This request requires more thought and a lot of QE, to make sure we don't end up losing in-flight data to the agent and collector. Somewhat related: #42

@jpkrohling jpkrohling added the enhancement New feature or request label Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants