-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move hard coded strings to constants #59
Comments
Working on this! |
@jpkrohling what about sharing constants in the same package? For instance, in Would you agree on creating a new file called Otherwise, how would you handle it? |
Yes, I think it's a good approach. Another option would be to have a dedicated package for constants, but I think I prefer to leave the constants closer to where they semantically belong to (jaeger-version belonging to the deployment package). |
Perfect. |
There are quite a few hard coded strings in the code, like
jaeger-agent
as the container name for the Jaeger Agent sidecar container. They should all move to constants.Where appropriate, types should be used to represent constant values.
The text was updated successfully, but these errors were encountered: