Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per-namespace inject annotation #373

Closed
jpkrohling opened this issue Apr 10, 2019 · 1 comment · Fixed by #897
Closed

Per-namespace inject annotation #373

jpkrohling opened this issue Apr 10, 2019 · 1 comment · Fixed by #897
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@jpkrohling
Copy link
Contributor

Looking at the istio documentation, I learned that we can annotate namespaces (seems obvious in hindsight). The operator could then support looking at the namespace's annotations to determine whether auto-injection should happen or not.

https://istio.io/docs/setup/kubernetes/install/kubernetes/
@jpkrohling jpkrohling added enhancement New feature or request good first issue Good for newcomers labels May 28, 2019
@jpkrohling jpkrohling added needs-triage New issues, in need of classification and removed needs-triage New issues, in need of classification labels Dec 16, 2019
@pavolloffay
Copy link
Member

Istio uses labels and not annotations for sidecar injection:

When you deploy your application using kubectl apply, the Istio sidecar injector will automatically inject Envoy containers into your application pods if they are started in namespaces labeled with istio-injection=enabled:

@pavolloffay pavolloffay mentioned this issue Feb 7, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Per namespace agent injection pavolloffay/jaeger-operator
2 participants
@jpkrohling @pavolloffay