New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Custom annotations/labels for Jaeger Route #2369

Open

gurfm opened this issue Dec 4, 2023 · 0 comments

Labels

gurfm commented Dec 4, 2023 •

edited

Loading

Requirement

Similarly to what was done for Ingress in #439 we would need to be able to customise annotations/labels on the Jaeger Route

Problem

annotations/labels provided in the Jaeger spec are currently ignored when creating the Jaeger Route

Proposal

Would you accept a PR that merges labels similarly to https://github.com/jaegertracing/jaeger-operator/blob/main/pkg/ingress/query.go#L32-L36 in https://github.com/jaegertracing/jaeger-operator/blob/main/pkg/route/query.go ?

Open questions

No response

gurfm added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment