Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use random ports in port forward and smoketests #154

Closed
pavolloffay opened this issue Dec 4, 2018 · 2 comments
Closed

Use random ports in port forward and smoketests #154

pavolloffay opened this issue Dec 4, 2018 · 2 comments

Comments

@pavolloffay
Copy link
Member

We use port forward in smoke tests introduced in #145.

The test forwards collector and query ports on host machine. However it uses standard ports (e.g. 16686) so the test might fail if there is jaeger server running locally.

Forwarder allows to use random port if it is specified as :16686 or 0:16686, however random ports are not exposed in the currently used version of go-client. Version 1.13.0 added API to get used ports.
@pavolloffay pavolloffay mentioned this issue Mar 8, 2019
Closed
@jpkrohling jpkrohling added needs-triage New issues, in need of classification and removed needs-triage New issues, in need of classification labels Dec 16, 2019
@jpkrohling
Copy link
Contributor

Is this still a goal?

@pavolloffay
Copy link
Member Author

This was done in #862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Use random port forward pavolloffay/jaeger-operator
2 participants
@jpkrohling @pavolloffay