Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Serve sampling strategies #9

Closed
pavolloffay opened this issue Feb 13, 2020 · 5 comments
Closed

Serve sampling strategies #9

pavolloffay opened this issue Feb 13, 2020 · 5 comments

Comments

@pavolloffay
Copy link
Member

pavolloffay commented Feb 13, 2020

Serve sampling strategies file

At the moment collector just proxies calls. Done in open-telemetry/opentelemetry-collector#448

@pavolloffay
Copy link
Member Author

Might be done in open-telemetry/opentelemetry-collector#500

@objectiser
Copy link

This has been done as part of open-telemetry/opentelemetry-collector#547 - however it only works over gRPC.

Now that /api/sampling is available in Jaeger collector, since 1.17.0, that should be supported aswell.

cc @joe-elliott

@objectiser objectiser added this to the Acceptance Criteria Met milestone Feb 28, 2020
@joe-elliott
Copy link
Member

joe-elliott commented Feb 28, 2020

The opentelemetry collector supports both http proxy (jaeger agent) and GRPC (jaeger collector) for serving sampling strategies. It's a little strange, but technically an operator could configure their opentelemetry collector to proxy to itself. The config would look something like:

receivers:
  jaeger:
    protocols:
      grpc:
    remote_sampling:
      fetch_endpoint: "localhost:14250"
      strategy_file: "/etc/strategies.json"

This work was done before we knew about the jaeger-opentelemetry-collector. Now that it exists maybe we should reevaluate some of the functionality in the collector.

@pavolloffay
Copy link
Member Author

@objectiser can this be closed?

@objectiser
Copy link

Not sure it is an ideal solution but provides a workaround, so guess we can close and open issues in the core repo to make improvements.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants