-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OTEL batch processor instead of ES bulk processor #2162
Comments
If we considered these OTel exporters (for storage) replacements for the Jaeger span writers, then we may avoid such issues, and also be able to directly support the OTel proto model -> storage, related to #2117 and jaegertracing/jaeger-opentelemetry-collector#6 . It may require duplication of code during the transition phase, but once the OTC is being used in place of the Jaeger Collector, this should result in the current Jaeger span writers being redundant anyway. |
The prerequisite is to switch Jaeger to OTEL. Then the storage writer will have to be refactored to work on the batch/spanData. |
Still not clear to me why we need to continue with using the current writer interfaces, rather than just porting the implementations to become exporter impls directly? |
Eventually we will have to do that. My objective was to avoid having two implementations at the same time. I am closing this and I will open a new issue for re-implementing all storage writers to use OTEL model directly. |
Created from jaegertracing/jaeger-opentelemetry-collector#14 (comment)
Elasticsearch bulk processor batches multiple requests into a single request which is sent to ES bulk API.
We could leverage OTEL batch processor https://github.com/open-telemetry/opentelemetry-collector/tree/master/processor/batchprocessor which has similar behavior. The batch processor batches
TraceData
from the same service and passes it forward once size or timeout criteria are satisfied.To use the batch processor we will have to refactor Jaeger span writer.
The text was updated successfully, but these errors were encountered: