Update proto for marshal issue

[rim99]

Which problem is this PR solving?

Resolves #4150

Description of the changes

• Make sure time fields works normally in generated go file

How was this change tested?

• Tested with PR Add optional time window in TraceGetParameters jaeger#6159

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[yurishkuro]

What does "works normally" mean? What wasn't working?

[rim99]

@yurishkuro Before this change, this test would fail
https://github.com/rim99/jaeger/blob/d00b4d3888475cb86668849b75246616fe3cb389/cmd/query/app/apiv3/grpc_handler_test.go#L81

It seems, server side cannot receive time values in request, and initialized these as 0001-01-01T00:00:00Z

[yurishkuro]

Before this change, this test would fail

I don't follow. The test is passing in the main repo, against the official proto. What specifically makes it fail?

[rim99]

The test in main repo doesn't test these 2 time fields. https://github.com/jaegertracing/jaeger/blob/main/cmd/query/app/apiv3/grpc_handler_test.go#L92-L94

In this proto file, tested time fields are here: https://github.com/jaegertracing/jaeger-idl/blob/main/proto/api_v3/query_service.proto#L60

I think we can either add more gogoproto extensions like current way, or remove these 2 existing gogoproto extension lines

(gogoproto.stdtime) = true

https://github.com/jaegertracing/jaeger-idl/blob/main/proto/api_v3/query_service.proto#L33-L37

[rim99]

@yurishkuro Removed gogoproto lines in proto file. Kind feel this should be the correct direction to move, since gogoproto project is already deprecated. And also to keep align with rest of lines.

[yurishkuro]

Removing gogo from time params is incorrect, it will prevent the generated fields in the struct from being time.Time

[yurishkuro]

Why can't we do it as in these PRs?

• Change start/end time to non-nullable #109
• Change start/end time in GetTrace request to not be pointers jaeger#6218

[rim99]

Tried with your latest merge. The go test would still fail

Running tool: /usr/bin/go test -timeout 30s -run ^TestGetTraceWithTimeWindow$ github.com/jaegertracing/jaeger/cmd/query/app/apiv3

=== RUN   TestGetTraceWithTimeWindow
    /home/xxx/projects/go/jaeger/cmd/query/app/apiv3/grpc_handler_test.go:140:
                Error Trace:    /home/xxx/projects/go/jaeger/cmd/query/app/apiv3/grpc_handler_test.go:140
                Error:          Received unexpected error:
                                rpc error: code = Internal desc = grpc: error while marshaling: proto: time.Time does not implement Marshal
                Test:           TestGetTraceWithTimeWindow
--- FAIL: TestGetTraceWithTimeWindow (0.00s)
FAIL
FAIL    github.com/jaegertracing/jaeger/cmd/query/app/apiv3     0.008s

[rim99]

BTW, why time field type matters here?

As I see the project: gogoproto, https://github.com/gogo/protobuf, it's deprecated. Last commit of this project is 2 years ago. No one maintains it actively.

I think before these time fields of request are widely referred, it's an opportunity to get rid of the deprecated extension. Since these 2 fields are the only things rely on gogproto

[yurishkuro]

Running tool: /usr/bin/go test -timeout 30s -run ^TestGetTraceWithTimeWindow$ github.com/jaegertracing/jaeger/cmd/query/app/apiv3

Please create a PR that demonstrates the test failure (without any other change)

[rim99]

Running tool: /usr/bin/go test -timeout 30s -run ^TestGetTraceWithTimeWindow$ github.com/jaegertracing/jaeger/cmd/query/app/apiv3

Please create a PR that demonstrates the test failure (without any other change)

Please check this draft PR: jaegertracing/jaeger#6228

[rim99]

No change