Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Tunein #117

Closed
patatman opened this issue Jul 31, 2016 · 7 comments
Closed

[Feature request] Tunein #117

patatman opened this issue Jul 31, 2016 · 7 comments

Comments

@patatman
Copy link

Hi,

I really like your web-client, and i mainly use spotify.
But occasionally i'd also like to listen to some TuneIn radio, is it possible to implement Tunein?

Thanks!

@jaedb
Copy link
Owner

jaedb commented Jul 31, 2016

In theory you should be able to install any extra Mopidy extensions and they should play within Spotmop. You can search all Mopidy extensions by using the Other tab in the search results.

Here is the extension it looks like you're after: https://github.com/kingosticks/mopidy-tunein but it doesn't look particularly active so it may be a little outdated. I'll have test run with it myself too for curiosity!

@patatman
Copy link
Author

Will give it a try, I already have the extention installed.
I'm also curious about your tests. It's a shame I can't write python yet :-(
I Gave a quick look at the code, and see if I can hack some sort of menu in there but I couldn't figure it out yet haha.

@bargru
Copy link

bargru commented Aug 10, 2016

The source code of the search controller shows that the search only takes place in "local" and "soundcloud". Change MopidyService.search (query, false, ['soundcloud:', 'local']) to MopidyService.search (query) and it works with any extension (also TuneIn).

If many extensions are installed, the search results are very confusing. It would be useful to filter for individual extensions.

@jaedb
Copy link
Owner

jaedb commented Aug 10, 2016

Ah, you're right there. I was hoping to be able to show all results across all BackendExtensions however there is no facility to list those that are installed. This would be required to facilitate filtering by source/BackendExtension.

That being said, I'll remove the filter on BackendExtension. Please note that this will mean you'll get search results for Spotify here as well as on the other tabs.

@bargru
Copy link

bargru commented Aug 10, 2016

The Android App Remotedy ( http://remotedy.com/ ; https://play.google.com/store/apps/details?id=se.anil.remotedy&hl=de ) is able to filter the search results.

I think that the "extended" search is better than the "local and soundcloud" search. But the search results are useless if it is not possible to filter and if there are many results.

I will ask the Remotedy developer how he has done the filtering.

@jaedb
Copy link
Owner

jaedb commented Aug 19, 2016

This will be included in the next release. Essentially Spotmop will now use the Mopidy core for performing searches, which will allow for filtering by source. The list of sources will default to Local and Spotify but can be customised in Settings.

@jaedb
Copy link
Owner

jaedb commented Aug 29, 2016

Resolved in v2.9

@jaedb jaedb closed this as completed Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants