From 2de66df19e647047848ec4ab849355d943e6de24 Mon Sep 17 00:00:00 2001 From: Jeff Brown Date: Tue, 10 May 2022 19:47:40 -0700 Subject: [PATCH] fix(config): override thermostat setpoint types for PE653 (#4588) --- .../config/config/devices/0x0005/pe653.json | 28 +++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/packages/config/config/devices/0x0005/pe653.json b/packages/config/config/devices/0x0005/pe653.json index 9148d4c67458..7d8866979aaf 100644 --- a/packages/config/config/devices/0x0005/pe653.json +++ b/packages/config/config/devices/0x0005/pe653.json @@ -80,6 +80,30 @@ "version": 1 } }, + // The firmware reports an thermostat setpoint type bitmap with an off-by-one error. + // It also reports a scale of 1 in ThermostatSetpointReport but rejects + // ThermostatSetpointSet requests with any scale other than 0 instead of 1 as would + // be expected according to the spec. + "interview": { + "0x43": { + "values": [ + { + "property": "supportedSetpointTypes", + "value": [1, 7] + }, + { + "property": "setpointScale", + "propertyKey": 1, + "value": 0 + }, + { + "property": "setpointScale", + "propertyKey": 7, + "value": 0 + } + ] + } + }, // The firmware handles requests on some endpoints incorrectly, often reporting garbage // that confuses discovery or inhibits operation. Remove all of these broken CCs. "remove": { @@ -88,6 +112,10 @@ "0x20": { "endpoints": [1, 2, 3, 4, 5] }, + // ThermostatSetpointCC: Endpoint 1 is a duplicate of the root. + "0x43": { + "endpoints": [1] + }, // ManufacturerSpecificCC: Endpoint 1 erroneously reports an incorrect manufacturer // and product ID, unlike on the root endpoint. "0x72": {