-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work with scoped modules #8
Comments
Thanks, I will look into this |
Looks like this is an npm issue: npm/npm#9175 I will investigate a stop-gap work around. |
A workaround seems like a very good idea. The npm issue appears to have stalled… |
To get this to work with a scoped module is just a matter of a simple fix on npm-bundle's index.js, on the glob.bind(null, '*') line. the problem is simply that npm-bundle does not find the package.json directly as child of the first folder in .nmpbundle/node_modules. In other words without scope you have:
With scopes you have:
so glob.bind(null, '*') returns @scope which does not have a package.json inside. So a general fix should be easy to cook, |
Any progress? |
Pretty easy to reproduce.
Simple install any scoped module and run your module.
The tgz file that is generated will not include the scoped module when the tarball is extracted.
The text was updated successfully, but these errors were encountered: