-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting - camelCase rather than underscore #108
Conversation
If you can think of a way this can be done without breaking backwards Naturally change for no reason is not really beneficial to the current Please see my recent blog post for more information:
|
This is a simple approach and it's backwards compatible as well. The main advantage here is that users of the library can choose between coding styles, and (as in my case) if their whole project is in camel case the use of this library doesn't have to differ. What do you think? |
This looks great and it is what I was hoping to see. If I was ever to make this change to Idiorm myself this is how I was going to do it. Do you use Paris? These changes will also need to be reflected in Paris as well. |
Awesome, thanks! I will be looking to use Paris as well, so I will fork it and work on those changes over the weekend. |
Great job, straightforward solution (and what I was considering as well, after your initial suggestion). The best part is a future version could switch to camel case for the main definitions, and use underscores as a deprecated backward-compatible option, without any loss of functionality. |
And @tag , therein lies the beauty and actual eventual aim :) |
@crhayes How have you been getting on with the Paris changes? |
@treffynnon I haven't had a chance to get to them yet, but thanks for the reminder. It's been a crazy couple of weeks with some freelance work and it slipped my mind. Still planning to do it as soon as things ease up. |
Thank you for the pull request. Would it be possible to get some tests and update documentation for the functionality, please? |
This is still going begging for tests and documentation. Anyone? |
How do you feel about having the methods converted to camel case so it is compliant with the PSR-1 spec? (https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-1-basic-coding-standard.md)
If you are open to it I can definitely help with the changes!