j2objcXcode now dependency of j2objcBuild

[brunobowden]

j2objcXcode:

• skips task if xcodeProjectDir is not set
• @input for project dependencies
• PodspecDetails is now serializable so it can be used for @input
• Cocoapods 0.39.0 is now installed in Travis build on OS X

Other changes:

• xcodeTargetsIos added to multiProject1
• j2objcPodspec now depends on j2objcPreBuild
• j2objcXcode now depends on j2objcPodspec
• j2objcAssemble now depends on j2objcXcode

[brunobowden]

PTAL

[advayDev1]

Do you want to just go ahead and do this?

[advayDev1]

Please add a comment to CHANGELOG.md also; LGTM when passes.

[advayDev1]

class PodspecDetails must be modified as follows to be an input:

@EqualsAndHashCode
static class PodspecDetails implements Serializable {
...
private static final long serialVersionUID = 1L
...
}

[brunobowden]

@advayDev1 - it also required implementing writeObject() and calling defaultWriteObject(). I added deserialization as well, so that I could test it end it end. Curiously, the @EqualsAndHashCode wasn't needed, so I wanted your opinion on that.

[advayDev1]

1. Not throwing without EqualsAndHashCode makes sense. However, I think you use it anyway: while serialization will work, you need it to make sure up-to-date checks are correct and even in Groovy, equality is referential unless overridden.
2. I'm not understanding why writeObject/defaultWriteObject were needed for you. I don't have them. Instead of doing that, consider using @AutoExternalize: http://docs.groovy-lang.org/2.4.5/html/gapi/groovy/transform/AutoExternalize.html

[advayDev1]

Aha: you don't have a default no-arg constructor for PodspecDetails. Ok this makes sense now

[brunobowden]

I expect that Gradle is comparing Serialized binary to Serialized binary, that way that can get consistent behaviour over time and across daemon runs - they can't keep the object around in memory. The writeDefaultObject is a necessary part of serialization.

[advayDev1]

I'd still suggest using @EqualsAndHashCode - we don't know what the implementation detail of Gradle is (I looked briefly, couldn't find it). Understood about writeDefaultObject, the point of @AutoExternalizable is to do that for you. (I'm still trying to figure out why I don't need AutoExternalizable nor implementations of Serializable - but that is an aside).

[brunobowden]

I've added back @EqualsAndHashCode. Since the serialization is working (and is tested), I'm fine with doing it the Java way with writeDefaultObject().

One concern I have is that getPodspecDependencies() is called 2-3 times during the gradle run. I'm surprised that this happens. Dependending on how large the dependency trees become, this may need caching.

I'll merge this once the build is green.

[advayDev1]

sg - LGTM