Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allPlatforms system test for Xcode and Android Studio #523

Merged
merged 1 commit into from
Oct 21, 2015

Conversation

brunobowden
Copy link
Contributor

Xcode 'allPlatforms' build:

  • TODO: needs setup from run-test.sh
  • TODO: get watchOS build working
  • iOS and OS X builds from shared project
  • App and unit tests for iOS and OS X
  • All generated from project defaults with minimal additional setup
  • Notable configuration:
    • iOS 7.0 (required for Swift)
    • OS X 10.4 (minimum supported by Xcode 7)
    • watchOS 2.0 (minimum for native watch apps)
    • Bitcode disabled until plugin handle bitcode build

Android 'allPlatforms' build:

  • 'shared' project + unit test
  • Application depends on shared project

Other Changes:

  • .gitignore for Xcode and Android Studio files

Fixes #521

TESTED=Manually

  • iOS 8.1 simulator
  • iOS 8.1 simulator unit tests
  • iOS 9.0 iPhone 6 Plus physical device
  • OS X 10.11 Mac App
  • OS X 10.11 Mac App unit tests
  • Android app simulator
  • Android app Nexus 6 physical device

@brunobowden
Copy link
Contributor Author

@advayDev1 - ignore this for now as it's missing most of the crucial files

@brunobowden
Copy link
Contributor Author

@advayDev1 - PTAL, it's now updated with the correct files. Also, no mention of 'brunobowden' anywhere in the files. No automatic setup yet but manually it works.

compile project(':shared')

compile fileTree(dir: 'libs', include: ['*.jar'])
compile 'com.android.support:appcompat-v7:21.0.3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will not work

@advayDev1
Copy link
Contributor

not much for me to comment on here as it seems 90% auto-generated. i'd recommend waiting for and merging to #518, as your build will push Travis over the timelimit.

Xcode 'allPlatforms' build:
- TODO: needs setup from run-test.sh
- Contains app and working unit tests for all platforms
- All generated from project defaults with minimal additional setup
- Notable configuration:
    * iOS 7.0 (required for Swift)
    * OS X 10.4 (minimum supported by Xcode 7)
    * watchOS 2.0 (minimum for native watch apps - not yet working)
    * Bitcode disabled until plugin handle bitcode build

Android 'allPlatforms' build:
- 'shared' project + unit test
- Application depends on shared project

Other Changes:
- .gitignore for Xcode and Android Studio files

TESTED=Manually
- iOS 8.1 simulator
- iOS 8.1 simulator unit tests
- iOS 9.0 iPhone 6 Plus physical device
- OS X 10.11 Mac App
- OS X 10.11 Mac App unit tests
- Android app simulator
- Android app Nexus 6 physical device
@brunobowden
Copy link
Contributor Author

Right now it's not building anything. So it won't impact the CI at all. Getting that work will obviously depend on #518.

@advayDev1
Copy link
Contributor

Sorry - that was my misunderstanding from the modification to simple1/build.gradle - LGTM then

brunobowden added a commit that referenced this pull request Oct 21, 2015
allPlatforms system test for Xcode and Android Studio
@brunobowden brunobowden merged commit 8f95dd5 into j2objc-contrib:master Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants