fix: logging

izatop · Jan 20, 2021 · 394bac1 · 394bac1
1 parent ec3bff4
commit 394bac1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/ws/src/Protocol/GQL/GQLProtoLayer.ts b/packages/ws/src/Protocol/GQL/GQLProtoLayer.ts
@@ -1,4 +1,4 @@
-import {assert, isFunction, isObject} from "@bunt/util";
+import {assert, isArray, isFunction, isObject} from "@bunt/util";
 import {GQLClientConnection} from "./GQLClientConnection";
 import {
     GQLClientOperation,
@@ -70,7 +70,7 @@ export class GQLProtoLayer {
     }
 
     private isReadableError(error: unknown): error is GQLError {
-        return isObject(error) && "message" in error;
+        return isObject(error) && ("message" in error || ("errors" in error && isArray(error.errors)));
     }
 
     private serializeError(error: unknown): GQLError {

diff --git a/packages/ws/src/WebSocketServer.ts b/packages/ws/src/WebSocketServer.ts
@@ -213,6 +213,8 @@ export class WebSocketServer<C extends IContext>
 
                 this.logger.debug("Accept connection");
                 ws.emit("connection", connection, req);
+                connection.on("error", (error) => this.logger.error(error.message, error));
+                connection.on("close", () => this.logger.debug("Close connection"));
 
                 setImmediate(() => this.handle(connection, async () => {
                     const state: Record<string, any> = {};
@@ -234,6 +236,7 @@ export class WebSocketServer<C extends IContext>
                 }));
             });
         } catch (error) {
+            this.logger.error(error.message, error);
             socket.destroy(error);
         }
     };
@@ -243,6 +246,7 @@ export class WebSocketServer<C extends IContext>
             await action();
             connection.close(WebSocketCloseReason.NORMAL_CLOSURE);
         } catch (error) {
+            this.logger.error(error.message, error);
             connection.close(WebSocketCloseReason.INTERNAL_ERROR);
         }
     }