Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jquery plugin, close popup behaviour #7

Open
leonardoxc opened this issue Mar 30, 2016 · 0 comments
Open

Jquery plugin, close popup behaviour #7

leonardoxc opened this issue Mar 30, 2016 · 0 comments

Comments

@leonardoxc
Copy link

It would be good for the user experience if the popup closed when the user clicks on the language selector once more

change required:

Line 163 replace
openPopup($popup, settings);
with
if ( settings._model.status == 'opened') {
closePopup($popup, settings);
} else {
openPopup($popup, settings);
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leonardoxc