-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for remaining entity types #24
Comments
Is there any way I can assist in these issues? Hatch also has my interest to have supported. (Recognizing the boundaries would already be enough for me) Kabeja seems to have a working implementation partially described here, is it an idea to port it? |
These entities are mainly ones that will require a custom reader (which I've done with other entities), but they will require much more work to get functioning properly. E.g., the HATCH entity is particularly nasty because it contains many boundary paths, with each boundary path containing soft pointers to many boundary shapes. A HATCH entity also contains many pattern data segments. |
I hate to bump such an old issue, but this project seems to be exactly what I am looking for. I would like to contribute to the project in respect to working on the implementation of the Table entity. Where would you suggest starting if I were to add to this project? |
I haven't attempted to support the I'd love some help working on the |
Is there any chance that limited HATCH support could be added that would just make it so I can get the "fill" color of LWPolyLine entities which have a hatch applied? My application just needs to be able to look up the DxfColor.Index of the fill, I have no needs to read the hatch boundary geometry. |
@wtaisto I can start looking into adding simple HATCH support. Do you have an existing file with a valid HATCH entity that I could test with? If you don't want the file made public you can email it directly to me at [email protected] and I'll delete it as soon as I'm done with it. Edit: Received drawing via email, will experiment. |
@wtaisto I've pushed a branch |
@brettfo Ok so I loaded the sample file I sent you using your hatch branch. The hatch entity is recognized, and the color does get loaded correctly. But I don't seem to see any geometry data in the object; the hatch.BoundaryPaths has a single item, but it contains no Edges. There were a couple of other properties that seemed like geometry candidates based on the names, but I didn't see anything which appeared to have path-like data. Where should I be looking for the geometry of the hatch border, or is there perhaps a single insertion point value, or something that would provide location? Thank you SO MUCH for looking at this, I really appreciate it! |
@wtaisto I think I figured out this issue; I misunderstood the meaning of a field. With the latest commit to the var file = DxfFile.Load(@"path\to\file\you\sent\me.dxf");
var hatch = file.Entities.OfType<DxfHatch>().First();
var boundaryPath = hatch.BoundaryPaths.First() as DxfHatch.PolylineBoundaryPath;
var boundaryPoints = boundaryPath.Vertices.Select(v => v.Location);
// at this point we have 4 boundary points that specify its location in the drawing |
Perfect! The boundary points come out exactly where I'd expect them to. |
Glad to hear it works, I've merged those changes to |
Awesome. Do you have a release cycle for your NuGet package, or will the changes appear there soon? |
I don't have any sort of release cycle, I just publish whenever there have been enough changes to warrant an update and when I get around to it. If a new release of the package would be useful to you, I can certainly publish another version. |
HATCHadded in c658e7c and 190c463MTEXTadded in 0b7a0c7The text was updated successfully, but these errors were encountered: